Add vlan_intf_object only if there are ipv4 or ipv6 mappings #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
approved these changes
Jan 21, 2021
abdosi
pushed a commit
that referenced
this pull request
Jan 28, 2021
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
d324eae (HEAD -> 201911, origin/201911) [PFCWD] Fix 'start' pfcwd command (sonic-net#1345) 235c61c [ecnconfig] handle backend port names when extracting port I/F ID from the port name (sonic-net#1361) 7f5c3b4 Drop explict 3 seconds pause between two object updates/deletes. (sonic-net#1359) 12c8992 add vlan_intf_object only if there are ipv4 or ipv6 mappings (sonic-net#1377) 52ce2c3 Add subcommand description to interfaces counters (sonic-net#1373) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add vlan_interface_object based on the presence of ipv4 or ipv6 mappings
- How I did it
Introduce a check for the count of ipv4 and ipv6 before adding vlan_interface_object and add it only if either of the mappings are present
- How to verify it
Look for the slice object and see that it contains no empty ipv4 and ipv6 mappings.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)