Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ecnconfig] Handle Multi ASIC backend port names when extracting port I/F #1361

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

smaheshm
Copy link
Contributor

- What I did
On Multi ASIC platforms ports names for backend ports have the following convention: 'Ethernet-BPxy'

Port ID extraction was failing for these backend port names.

- How I did it

Fix the port ID extraction for backend port names.

- How to verify it

Manual:

before:
admin@str-sonic-acs-2:~$ sudo ip netns exec asic0 ecnconfig -q 3
Exception caught:  invalid literal for int() with base 10: '-BP48'

After:
admin@str-sonic-acs-2:~$ sudo ip netns exec asic0 ecnconfig -q 3
ECN status:
queue 3: on

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

@smaheshm
Copy link
Contributor Author

retest this please

@smaheshm smaheshm merged commit f4edba1 into sonic-net:master Jan 20, 2021
abdosi pushed a commit that referenced this pull request Jan 28, 2021
@smaheshm smaheshm deleted the ecnconfig branch February 26, 2021 22:33
anand-kumar-subramanian pushed a commit to anand-kumar-subramanian/sonic-utilities that referenced this pull request Mar 2, 2021
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
d324eae (HEAD -> 201911, origin/201911) [PFCWD] Fix 'start' pfcwd command (sonic-net#1345)
235c61c [ecnconfig] handle backend port names when extracting port I/F ID from the port name (sonic-net#1361)
7f5c3b4 Drop explict 3 seconds pause between two object updates/deletes. (sonic-net#1359)
12c8992 add vlan_intf_object only if there are ipv4 or ipv6 mappings (sonic-net#1377)
52ce2c3 Add  subcommand description to interfaces counters (sonic-net#1373)
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants