[MACsec]: Support switchId and portId for gearbox #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boyang Yu <byu@arista.com>
|
@Pterosaur , to review |
|
@byu343 , can you enhance the vstest? |
|
lgtm |
Pterosaur
approved these changes
Apr 25, 2021
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
Signed-off-by: Boyang Yu <byu@arista.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…ddress type (sonic-net#1717) #### What I did Update CLI reference document following PR : sonic-net/sonic-buildimage#8211 Add a new API on utilities_common to get IP type. #### How I did it - Update doc/Command-Reference.md with new DHCP CLI. - Add ipaddress_type API to utilities_common/cli.py #### How to verify it - Build an image with PR sonic-net/sonic-buildimage#8211 and this PR. - Run DHCP CLI commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
To support MACsec on Arista 7280cr3, which uses external gearbox chips, the switch Id and port Id used in MACsec SAI APIs have to be coming from the context of the gearbox chips. This change implements it by saving the Ids in initGearboxPort() and used them in MACsecOrchContext.
Why I did it
How I verified it
Details if related