[dhcp_relay] Adapt config/show CLI commands to support DHCPv6 relay #8211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support multiple dhcp servers assignment in one command Fix IP validation Adapt and add new UT cases Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
|
This pull request introduces 1 alert when merging 6ade59c into c89b62e - view on LGTM.com new alerts:
|
|
@tahmed-dev can you please review this PR? |
|
@tahmed-dev - please help with merge asap, needed for 202106 release |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Aug 23, 2021
…ddress type (#1717) #### What I did Update CLI reference document following PR : sonic-net/sonic-buildimage#8211 Add a new API on utilities_common to get IP type. #### How I did it - Update doc/Command-Reference.md with new DHCP CLI. - Add ipaddress_type API to utilities_common/cli.py #### How to verify it - Build an image with PR sonic-net/sonic-buildimage#8211 and this PR. - Run DHCP CLI commands
|
@shlomibitton, can you please the build failure? |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Hey @tahmed-dev we need this PR to merge in order to fix the build issue: |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@tahmed-dev all checked are passing now, can we proceed and merge? |
judyjoseph
pushed a commit
that referenced
this pull request
Aug 25, 2021
…8211) #### Why I did it - Adapt config/show CLI commands to support DHCPv6 relay - Support multiple dhcp servers assignment in one command - Fix IP validation - Adapt UT and add new UT cases #### How I did it - Modify config/show dhcp relay files - Modify config/show UT files #### How to verify it This PR has a dependency on PR sonic-net/sonic-utilities#1717 Build an image with the dependent PR and this PR Use config/show DHCPv6 relay commands.
judyjoseph
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Aug 26, 2021
…ddress type (#1717) #### What I did Update CLI reference document following PR : sonic-net/sonic-buildimage#8211 Add a new API on utilities_common to get IP type. #### How I did it - Update doc/Command-Reference.md with new DHCP CLI. - Add ipaddress_type API to utilities_common/cli.py #### How to verify it - Build an image with PR sonic-net/sonic-buildimage#8211 and this PR. - Run DHCP CLI commands
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
…ddress type (#1717) #### What I did Update CLI reference document following PR : sonic-net/sonic-buildimage#8211 Add a new API on utilities_common to get IP type. #### How I did it - Update doc/Command-Reference.md with new DHCP CLI. - Add ipaddress_type API to utilities_common/cli.py #### How to verify it - Build an image with PR sonic-net/sonic-buildimage#8211 and this PR. - Run DHCP CLI commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton shlomibi@nvidia.com
Why I did it
How I did it
How to verify it
This PR has a dependency on PR sonic-net/sonic-utilities#1717
Build an image with the dependent PR and this PR
Use config/show DHCPv6 relay commands.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)