Swssconfig #11

hrachya-m · 2016-03-31T22:33:28Z

No description provided.

eladraz · 2016-04-03T05:47:53Z

swssconfig/swssconfig.cpp

+using json = nlohmann::json;
+
+int db_port							= 6379;
+const char* const hostname 			= "localhost";


Please read those values from command line (with defaults as defines)

This behavior is based on neighsyncd as a sample. Most of apps use hardcoded port and host name.
If we decide to change all of them it can be done in one changelist.

stcheng · 2016-04-04T22:16:00Z

swssconfig/swssconfig.cpp

+
+int main(int argc, char **argv)
+{
+	Logger::setMinPrio(Logger::SWSS_DEBUG);


do we need to set to DEBUG?

* replaced tabs with spaces * change type& var, to type &var * change to conditional build on swssconfig if json.hpp is present - eliminates need of 3rd party license.

…file * Adding application which loads db settings from json file * Modified configure.ac and Makefile to include swssconfig into build. Signed-off-by: Hrachya Mughnetsyan hrachya@mellanox.com

* replaced tabs with spaces * change type& var, to type &var * change to conditional build on swssconfig if json.hpp is present - eliminates need of 3rd party license.

* dropped fpm-like approach of build process. Changed build of swssconfig to use local copy of json.hpp

kcudnik · 2016-04-07T05:13:27Z

swssconfig/swssconfig.cpp

+
+using namespace std;
+using namespace swss;
+using json = nlohmann::json;


Please don't use "using namespace", please use full namespace like "std::string" instead of "string" this will avoid making conflicts with same name in multiple namespaces

It's source file (CPP) and not include, it shouldn't cause conflicts. I think it's okay.

* added sample json input file for swssconfig. Signed-off-by: Hrachya Mughnetsyan hrachya@mellanox.com

stcheng · 2016-04-12T00:54:21Z

acked by Shuotian Cheng

* Create sonic-features.md * Updating with NAS and PAS contribution

* DPB ACL dependency implemenatation and test cases * Code-review comments addressed * ACL empty port list support, Codereview comments, and Bug fixes

**What I did** Fix the Mem Leak by moving the raw pointers in type_maps to use smart pointers **Why I did it** ``` Indirect leak of 83776 byte(s) in 476 object(s) allocated from: #0 0x7f0a2a414647 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:99 #1 0x5555590cc923 in __gnu_cxx::new_allocator, std::allocator > const, referenced_object> > >::allocate(unsigned long, void const*) /usr/include/c++/10/ext/new_allocator.h:115 #2 0x5555590cc923 in std::allocator_traits, std::allocator > const, referenced_object> > > >::allocate(std::allocator, std::allocator > const, referenced_object> > >&, unsigned long) /usr/include/c++/10/bits/alloc_traits.h:460 #3 0x5555590cc923 in std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_get_node() /usr/include/c++/10/bits/stl_tree.h:584 #4 0x5555590cc923 in std::_Rb_tree_node, std::allocator > const, referenced_object> >* std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_create_node, std::allocator > const&>, std::tuple<> >(std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:634 #5 0x5555590cc923 in std::_Rb_tree_iterator, std::allocator > const, referenced_object> > std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_emplace_hint_unique, std::allocator > const&>, std::tuple<> >(std::_Rb_tree_const_iterator, std::allocator > const, referenced_object> >, std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:2461 #6 0x5555590e8757 in std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::operator[](std::__cxx11::basic_string, std::allocator > const&) /usr/include/c++/10/bits/stl_map.h:501 #7 0x5555590d48b0 in Orch::setObjectReference(std::map, std::allocator >, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*, std::less, std::allocator > >, std::allocator, std::allocator > const, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*> > >&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&) orchagent/orch.cpp:450 #8 0x5555594ff66b in QosOrch::handleQueueTable(Consumer&, std::tuple, std::allocator >, std::__cxx11::basic_string, std::allocator >, std::vector, std::allocator >, std::__cxx11::basic_string, std::allocator > >, std::allocator, std::allocator >, std::__cxx11::basic_string, std::allocator > > > > >&) orchagent/qosorch.cpp:1763 #9 0x5555594edbd6 in QosOrch::doTask(Consumer&) orchagent/qosorch.cpp:2179 #10 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:241 #11 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:238 #12 0x5555590c8743 in Consumer::execute() orchagent/orch.cpp:235 #13 0x555559090dad in OrchDaemon::start() orchagent/orchdaemon.cpp:755 #14 0x555558e9be25 in main orchagent/main.cpp:766 #15 0x7f0a299b6d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09) ```

eladraz reviewed Apr 3, 2016
View reviewed changes

stcheng force-pushed the master branch from d2864a6 to 2b6997c Compare April 4, 2016 21:47

stcheng reviewed Apr 4, 2016
View reviewed changes

swssconfig/swssconfig.cpp

int main(int argc, char **argv)

{

Logger::setMinPrio(Logger::SWSS_DEBUG);

Copy link

Contributor

stcheng Apr 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to set to DEBUG?

hrachya-m force-pushed the swssconfig branch from b70378c to 8559316 Compare April 5, 2016 00:12

Hrachya Mughnetsyan added 2 commits April 4, 2016 17:18

swssconfig: Adding new application which loads db settings from json …

a68bc13

…file * Adding application which loads db settings from json file * Modified configure.ac and Makefile to include swssconfig into build. Signed-off-by: Hrachya Mughnetsyan hrachya@mellanox.com

Follow-up on sonic-net#11 comments

cab5874

* replaced tabs with spaces * change type& var, to type &var * change to conditional build on swssconfig if json.hpp is present - eliminates need of 3rd party license.

hrachya-m force-pushed the swssconfig branch from 8559316 to cab5874 Compare April 5, 2016 00:19

Follow-up [2] on sonic-net#11 comments

760f465

* dropped fpm-like approach of build process. Changed build of swssconfig to use local copy of json.hpp

kcudnik reviewed Apr 7, 2016
View reviewed changes

[swssconfig] Add json sample file and output log

e7450f8

* added sample json input file for swssconfig. Signed-off-by: Hrachya Mughnetsyan hrachya@mellanox.com

stcheng closed this Apr 12, 2016

hrachya-m deleted the swssconfig branch August 29, 2016 21:32

vharish02 pushed a commit to vharish02/sonic-swss that referenced this pull request Aug 6, 2018

Gh pages (sonic-net#11)

c5ad681

* Create sonic-features.md * Updating with NAS and PAS contribution

ishidawataru pushed a commit to ishidawataru/sonic-swss that referenced this pull request Aug 29, 2018

Add attribute retry_on for configdb connection (sonic-net#11)

d476a25

vasant17 added a commit to vasant17/sonic-swss that referenced this pull request Dec 13, 2019

DPB ACL dependency implementation and test cases (sonic-net#11)

77db91c

vasant17 added a commit to vasant17/sonic-swss that referenced this pull request Feb 2, 2020

DPB ACL dependency implementation and test cases (sonic-net#11)

36f26aa

vasant17 added a commit to vasant17/sonic-swss that referenced this pull request Feb 11, 2020

DPB ACL dependency implementation and test cases (sonic-net#11)

b1f2ac9

vasant17 added a commit to vasant17/sonic-swss that referenced this pull request Mar 6, 2020

DPB ACL dependency implementation and test cases (sonic-net#11)

283a229

skbarista mentioned this pull request Nov 29, 2022

sonic-swss: Fix orchagent crash in generateQueueMapPerPort. #2552

Merged

oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023

pkg: Adding syncd.init file for Broadcom SAI (sonic-net#11)

4e86aad

lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this pull request Apr 2, 2023

[sff8472] Fix incorrect VendorOUI decode type. (sonic-net#11)

6d8c940

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swssconfig #11

Swssconfig #11

hrachya-m commented Mar 31, 2016

eladraz Apr 3, 2016

hrachya-m Apr 4, 2016

stcheng Apr 4, 2016

kcudnik Apr 7, 2016

eladraz Apr 7, 2016

stcheng commented Apr 12, 2016

Swssconfig #11

Swssconfig #11

Conversation

hrachya-m commented Mar 31, 2016

eladraz Apr 3, 2016

Choose a reason for hiding this comment

hrachya-m Apr 4, 2016

Choose a reason for hiding this comment

stcheng Apr 4, 2016

Choose a reason for hiding this comment

kcudnik Apr 7, 2016

Choose a reason for hiding this comment

eladraz Apr 7, 2016

Choose a reason for hiding this comment

stcheng commented Apr 12, 2016