swss/orchagent : Fixed the crash on error returned by select. #10

garyachy · 2016-03-31T19:56:57Z

Crash happens when the select call in OrchDaemon start method
returns an error and getOrchByConsumer returns a null pointer.

Signed-off-by: Denys Haryachyy Denys.Haryachyy@caviumnetworks.com

…face. 1. Incorrect ip prefix parsing is fixed. 2. IntfsTable map is updated after removal of ip address from the interface. Signed-off-by: Denys Haryachyy <Denys.Haryachyy@caviumnetworks.com>

Crash happens when the select call in OrchDaemon start method returns an error and getOrchByConsumer returns a null pointer. Signed-off-by: Denys Haryachyy <Denys.Haryachyy@caviumnetworks.com>

eladraz · 2016-04-03T06:23:26Z

Can you explain why crash happens? Why the select() fails with error?

garyachy · 2016-04-03T14:18:18Z

Segmentation fault happens as far as there is no check on null pointer.
Select returns with an error whenever a signal is received by the application.

eladraz · 2016-04-03T16:38:20Z

I see, when someone INT signal.
Isn't is better to do exit() or return instead of continue?

stcheng · 2016-04-04T21:59:26Z

continue works as long as we print out some error messages i think.

kcudnik · 2016-04-08T03:01:13Z

orchagent/orchdaemon.cpp

@@ -51,7 +51,10 @@ void OrchDaemon::start()

        ret = m_select->select(&s, &fd, 1);
        if (ret == Select::ERROR)
+        {
            SWSS_LOG_NOTICE("Error!\n");


Add more information about what error? And please remove \n from the end of log

Added errno output that will help identify the reason of an error.

The error is caused by a signal received. Signed-off-by: Denys Haryachyy <Denys.Haryachyy@caviumnetworks.com>

garyachy · 2016-04-14T08:37:08Z

I have fixed error message. Please merge.

stcheng · 2016-04-14T18:25:45Z

ack

stcheng · 2016-04-14T18:28:40Z

thanks

Updated architecture doc with NAS and PAS contribution

* Notifications should use ntf consumer and producer * Use SelectableEvent to notify thread end * Remove signal handler * Implement service_method_table * Add getopt options

…e, delete file and read directly from EEPROM (sonic-net#10) * [sonic_eeprom] If reading from what appears to be a corrupt cache file, delete file and read directly from EEPROM * Refactor to eliminate recursion

**What I did** Fix the Mem Leak by moving the raw pointers in type_maps to use smart pointers **Why I did it** ``` Indirect leak of 83776 byte(s) in 476 object(s) allocated from: #0 0x7f0a2a414647 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:99 #1 0x5555590cc923 in __gnu_cxx::new_allocator, std::allocator > const, referenced_object> > >::allocate(unsigned long, void const*) /usr/include/c++/10/ext/new_allocator.h:115 #2 0x5555590cc923 in std::allocator_traits, std::allocator > const, referenced_object> > > >::allocate(std::allocator, std::allocator > const, referenced_object> > >&, unsigned long) /usr/include/c++/10/bits/alloc_traits.h:460 #3 0x5555590cc923 in std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_get_node() /usr/include/c++/10/bits/stl_tree.h:584 #4 0x5555590cc923 in std::_Rb_tree_node, std::allocator > const, referenced_object> >* std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_create_node, std::allocator > const&>, std::tuple<> >(std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:634 #5 0x5555590cc923 in std::_Rb_tree_iterator, std::allocator > const, referenced_object> > std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_emplace_hint_unique, std::allocator > const&>, std::tuple<> >(std::_Rb_tree_const_iterator, std::allocator > const, referenced_object> >, std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:2461 #6 0x5555590e8757 in std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::operator[](std::__cxx11::basic_string, std::allocator > const&) /usr/include/c++/10/bits/stl_map.h:501 #7 0x5555590d48b0 in Orch::setObjectReference(std::map, std::allocator >, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*, std::less, std::allocator > >, std::allocator, std::allocator > const, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*> > >&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&) orchagent/orch.cpp:450 #8 0x5555594ff66b in QosOrch::handleQueueTable(Consumer&, std::tuple, std::allocator >, std::__cxx11::basic_string, std::allocator >, std::vector, std::allocator >, std::__cxx11::basic_string, std::allocator > >, std::allocator, std::allocator >, std::__cxx11::basic_string, std::allocator > > > > >&) orchagent/qosorch.cpp:1763 #9 0x5555594edbd6 in QosOrch::doTask(Consumer&) orchagent/qosorch.cpp:2179 #10 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:241 #11 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:238 #12 0x5555590c8743 in Consumer::execute() orchagent/orch.cpp:235 #13 0x555559090dad in OrchDaemon::start() orchagent/orchdaemon.cpp:755 #14 0x555558e9be25 in main orchagent/main.cpp:766 #15 0x7f0a299b6d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09) ```

lguohan and others added 3 commits March 28, 2016 20:48

update build procedure

f8e245c

swss/orchagent : Fixed the case of removing ip address from the inter…

d2864a6

…face. 1. Incorrect ip prefix parsing is fixed. 2. IntfsTable map is updated after removal of ip address from the interface. Signed-off-by: Denys Haryachyy <Denys.Haryachyy@caviumnetworks.com>

swss/orchagent : Fixed the crash on error returned by select.

f282f93

Crash happens when the select call in OrchDaemon start method returns an error and getOrchByConsumer returns a null pointer. Signed-off-by: Denys Haryachyy <Denys.Haryachyy@caviumnetworks.com>

stcheng force-pushed the master branch from d2864a6 to 2b6997c Compare April 4, 2016 21:47

kcudnik reviewed Apr 8, 2016
View reviewed changes

swss/orchagent : Print errno when returned from select on error.

7c29be0

The error is caused by a signal received. Signed-off-by: Denys Haryachyy <Denys.Haryachyy@caviumnetworks.com>

stcheng closed this Apr 14, 2016

vharish02 pushed a commit to vharish02/sonic-swss that referenced this pull request Aug 6, 2018

Updated architecture doc with NAS and PAS contribution (sonic-net#10)

1d59fe0

Updated architecture doc with NAS and PAS contribution

skbarista mentioned this pull request Nov 29, 2022

sonic-swss: Fix orchagent crash in generateQueueMapPerPort. #2552

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

swss/orchagent : Fixed the crash on error returned by select. #10

swss/orchagent : Fixed the crash on error returned by select. #10

garyachy commented Mar 31, 2016

eladraz commented Apr 3, 2016

garyachy commented Apr 3, 2016

eladraz commented Apr 3, 2016

stcheng commented Apr 4, 2016

kcudnik Apr 8, 2016

garyachy Apr 12, 2016

garyachy commented Apr 14, 2016

stcheng commented Apr 14, 2016

stcheng commented Apr 14, 2016

swss/orchagent : Fixed the crash on error returned by select. #10

swss/orchagent : Fixed the crash on error returned by select. #10

Conversation

garyachy commented Mar 31, 2016

eladraz commented Apr 3, 2016

garyachy commented Apr 3, 2016

eladraz commented Apr 3, 2016

stcheng commented Apr 4, 2016

kcudnik Apr 8, 2016

Choose a reason for hiding this comment

garyachy Apr 12, 2016

Choose a reason for hiding this comment

garyachy commented Apr 14, 2016

stcheng commented Apr 14, 2016

stcheng commented Apr 14, 2016