Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snmp_interfaces] add snmp interface counters check #1796

Merged
merged 3 commits into from
Jul 7, 2020
Merged

[snmp_interfaces] add snmp interface counters check #1796

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee4fa51
[snmp_interfaces] add snmp interface countes check
Jun 17, 2020
106091c
expect l3vlan counters only on Mellanox
Jun 18, 2020
32cf545
fix pep8 warnings
Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 41 additions & 2 deletions tests/snmp/test_snmp_interfaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ def test_snmp_interfaces(duthost, localhost, creds):
hostip = duthost.host.options['inventory_manager'].get_host(duthost.hostname).vars['ansible_host']

snmp_facts = localhost.snmp_facts(host=hostip, version="v2c", community=creds["snmp_rocommunity"])['ansible_facts']
config_facts = duthost.config_facts(host=duthost.hostname, source="persistent")['ansible_facts']
config_facts = duthost.config_facts(host=duthost.hostname, source="persistent")['ansible_facts']

snmp_ifnames = [ v['name'] for k, v in snmp_facts['snmp_interfaces'].items() ]
snmp_ifnames = [v['name'] for k, v in snmp_facts['snmp_interfaces'].items()]
print snmp_ifnames

# Verify all physical ports in snmp interface list
Expand All @@ -24,3 +24,42 @@ def test_snmp_interfaces(duthost, localhost, creds):
# Verify management port in snmp interface list
for name in config_facts.get('MGMT_INTERFACE', {}):
assert name in snmp_ifnames

# Verify Vlan interfaces in snmp interface list
for name in config_facts.get('VLAN_INTERFACE', {}):
assert name in snmp_ifnames


def test_snmp_interface_counters(duthost, localhost, creds):
"""Make sure Interface MIB has counters available"""
hostip = duthost.host.options['inventory_manager'].get_host(duthost.hostname).vars['ansible_host']
snmp_facts = localhost.snmp_facts(host=hostip, version="v2c", community=creds["snmp_rocommunity"])['ansible_facts']

for k, v in snmp_facts['snmp_interfaces'].items():
if "Ethernet" in v['name'] or "PortChannel" in v['name']:
if ('ifInErrors' not in v or \
'ifOutErrors' not in v or \
'ifInDiscards' not in v or \
'ifHCInOctets' not in v or \
'ifOutDiscards' not in v or \
'ifHCOutOctets' not in v or \
'ifInUcastPkts' not in v or \
'ifOutUcastPkts' not in v):
pytest.fail("interface %s does not have counters" % v['name'])


def test_snmp_l3vlan_counters(duthost, localhost, creds):
"""Make sure Interface MIB has counters available for l3vlan"""
if duthost.facts["asic_type"] not in ["mellanox"]:
pytest.skip("Skip test due to RIF counter not supported on {}".format(duthost.facts["platform"]))

hostip = duthost.host.options['inventory_manager'].get_host(duthost.hostname).vars['ansible_host']
snmp_facts = localhost.snmp_facts(host=hostip, version="v2c", community=creds["snmp_rocommunity"])['ansible_facts']

for k, v in snmp_facts['snmp_interfaces'].items():
if "Vlan" in v['name']:
if ('ifInErrors' not in v or \
'ifOutErrors' not in v or \
'ifInUcastPkts' not in v or \
'ifOutUcastPkts' not in v):
pytest.fail("interface %s does not have counters" % v['name'])