[snmp_interfaces] add snmp interface counters check #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2020 17:41
Change-Id: Iead56ba71845ee90a65f521d8a1069102cc59112 Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Change-Id: Iaccb49c13e9b2260fee6f5a1e78dbd30311c2c80 Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
volodymyrsamotiy
approved these changes
Jun 23, 2020
wangxin
reviewed
Jun 29, 2020
tests/snmp/test_snmp_interfaces.py
Outdated
| def test_snmp_l3vlan_counters(duthost, localhost, creds): | ||
| """Make sure Interface MIB has counters available for l3vlan""" | ||
| if duthost.facts["asic_type"] not in ["mellanox"]: | ||
| pytest.skip("Skip test due to RIF counter not supported{}".format(duthost.facts["platform"])) |
There was a problem hiding this comment.
not supported{} => not supported on {}
wangxin
approved these changes
Jun 29, 2020
qiluo-msft
reviewed
Jun 29, 2020
tests/snmp/test_snmp_interfaces.py
Outdated
| for k, v in snmp_facts['snmp_interfaces'].items(): | ||
| if "Ethernet" in v['name'] or "PortChannel" in v['name']: | ||
| if not v.has_key('ifInErrors') or \ | ||
| not v.has_key('ifOutErrors') or \ |
There was a problem hiding this comment.
The indentation is weird. Please check examples in https://legacy.python.org/dev/peps/pep-0008/#indentation
Change-Id: Ie64d0e856ff94bdbc30c73ba610643ba5126bc2d Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
lguohan
pushed a commit
that referenced
this pull request
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Update test_snmp_interfaces.py
Depends on snmpagent#133
Type of change
Approach
What is the motivation for this PR?
SNMP Interface MIB was updated recently, with vlan interface support.
How did you do it?
How did you verify/test it?
Run the test
Any platform specific information?
Vlan interface counters will be present only if RIF counters are supported. Test this only on Mellanox.
Supported testbed topology if it's a new test case?
Documentation