Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:15818] [syncd.sh] Clear semaphore before updating firmware #16066

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

mssonicbld
Copy link
Collaborator

Why I did it

The hw resources should be released before updating firmware.

How I did it

Added logic to release hw resources in syncd.sh script

How to verify it

Scenario:

  1. Write a bash script to kill mlxfwmanager process in the infinite loop and run it in the background.
#!/bin/bash

while :;
do
 pkill -9 mlnxfwmanager
done
  1. Try to start the mlnfwmanager utility a few times.
  2. Stop the bash script.
  3. Start the mlxfwmanager and make sure that the semaphore is taken.
  4. Run the config reload -y command and make sure that all the dockers are in up state.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Why I did it
The hw resources should be released before updating firmware.

How I did it
Added logic to release hw resources in syncd.sh script

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@mssonicbld
Copy link
Collaborator Author

Original PR: #15818

@mssonicbld mssonicbld merged commit 1e19747 into sonic-net:202211 Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants