[syncd.sh] Clear semaphore before updating firmware #15818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
8 tasks
vivekrnv
approved these changes
Jul 18, 2023
8 tasks
|
@qiluo-msft could you please help to review and merge this PR and cherry-picks? |
keboliu
added a commit
to keboliu/sonic-buildimage
that referenced
this pull request
Jul 25, 2023
qiluo-msft
approved these changes
Aug 4, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 7, 2023
Why I did it The hw resources should be released before updating firmware. How I did it Added logic to release hw resources in syncd.sh script Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 7, 2023
Why I did it The hw resources should be released before updating firmware. How I did it Added logic to release hw resources in syncd.sh script Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
|
Cherry-pick PR to 202211: #16066 |
|
Cherry-pick PR to 202305: #16067 |
8 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 7, 2023
Why I did it The hw resources should be released before updating firmware. How I did it Added logic to release hw resources in syncd.sh script Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
8 tasks
|
Cherry-pick PR to 202205: #16068 |
mssonicbld
added a commit
that referenced
this pull request
Aug 7, 2023
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
|
@vadymhlushko-mlnx cherry pick PR didn't pass PR checker. Please check!!! |
2 similar comments
|
@vadymhlushko-mlnx cherry pick PR didn't pass PR checker. Please check!!! |
|
@vadymhlushko-mlnx cherry pick PR didn't pass PR checker. Please check!!! |
|
Sorry. automation issue. |
yxieca
pushed a commit
that referenced
this pull request
Aug 10, 2023
Why I did it The hw resources should be released before updating firmware. How I did it Added logic to release hw resources in syncd.sh script Signed-off-by: Vadym Hlushko <vadymh@nvidia.com> Co-authored-by: Vadym Hlushko <62022266+vadymhlushko-mlnx@users.noreply.github.com>
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
Why I did it The hw resources should be released before updating firmware. How I did it Added logic to release hw resources in syncd.sh script Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The hw resources should be released before updating firmware.
How I did it
Added logic to release hw resources in
syncd.shscriptHow to verify it
Scenario:
mlxfwmanagerprocess in the infinite loop and run it in the background.mlnfwmanagerutility a few times.mlxfwmanagerand make sure that the semaphore is taken.config reload -ycommand and make sure that all the dockers are in up state.Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)