[system-health] Led color shall be controlled by configuration when system is booting #12487
Conversation
|
@qiluo-msft @prgeor could you please assign/suggest who can review this PR? |
| @@ -20,7 +20,7 @@ class Config(object): | |||
| DEFAULT_LED_CONFIG = { | |||
| 'fault': 'red', | |||
| 'normal': 'green', | |||
| 'booting': 'orange_blink' | |||
| 'booting': 'red' | |||
There was a problem hiding this comment.
why changed from 'orange' blinking to 'red'? How to distinguish between fault state or system hung stat during boot?
There was a problem hiding this comment.
This is for backward compatible. Before this change, booting stage is not used, so "orange_blink" is not used too, system led color is always red during system booting time because not all services are ready. In the new change, I set "booting stage" to red to make sure backward compatible: if user does not provide system health configuration file, system led color will be red which is the same behavior as before; otherwise, system led will be set to the color specified in system health configuration file.
liat-grozovik
requested review from
prgeor
and removed request for
lguohan and
qiluo-msft
|
@prgeor kindly reminder. we need this fix in 202211 and 202205. Lets please close the review feedback |
|
Hi @yxieca , could you please help cherry-pick to 202205? |
…ystem is booting (sonic-net#12487) * [system-health] Led color shall be controlled by configuration when system is booting * Fix unit test issue
|
Cherry-pick PR to 202205: #12909 |
…ystem is booting (#12487) * [system-health] Led color shall be controlled by configuration when system is booting * Fix unit test issue
HLD: sonic-net/SONiC#1106
Why I did it
Currently, system status LED is always red during booting stage. User cannot tell if it is a real issue or system is under initialization. This HLD change introduces a booting stage for the system health daemon and allow user to configure the system status led color for booting state.
How I did it
Led color is determined by system status and uptime.
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)