[system-health] Led color shall be controlled by configuration when system is booting #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
keboliu
approved these changes
Oct 27, 2022
| |:----------------:|:--------------------:|:-------------------------------------------------------------------------:| | ||
| | booting | ${led_color.booting} | System up time is less that 5 mins and not all services/devices are ready | | ||
| | normal | ${led_color.normal} | All services/devices are in good state | | ||
| | fault | ${led_color.fault} | Not all services/devices are in good state | |
There was a problem hiding this comment.
Do get into fault state also when boot time is more than 5 min and not all is ok, right?
|
@zhangyanzhao I suggest to go a head with the merge. Any objection? |
prgeor
reviewed
Nov 14, 2022
| DEFAULT_LED_CONFIG = { | ||
| 'fault': 'red', | ||
| 'normal': 'green', | ||
| 'booting': 'red' |
There was a problem hiding this comment.
can we have some other color other than 'red' which is already used for indicating 'fault'?
There was a problem hiding this comment.
Before this PR, there is no booting stage. So, only two cases:
- System is all good, LED is green
- System is not all good, LED is red
Booting stage is introduced by this PR. So, setting "red" as the default value for booting stage is for backward compatible. User can override this value by using a system health configuration file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, system status LED is always red during booting stage. User cannot tell if it is a real issue or system is under initialization. This HLD change introduces a booting stage for the system health daemon and allow user to configure the system status led color for booting state.
PRs: