GoReleaser #80

DarthHater · 2020-02-22T21:42:29Z

@nrcook is typically a genius, this is a freshened up version of what he did in #20 .

This pull request makes the following changes:

Moves from TravisCI to CircleCI (niceities, and we use CircleCI in most of our newer projects)
- Adds saving test result artifacts, etc... for showing failures in the CircleCI UI
Adds goreleaser config

This should support Alpine Linux as we disable CGO, so all current cases should be covered.

We were able to 1:1 it with the current Nancy releases, and tested it out on @allenhsieh fork of Nancy:

https://github.com/allenhsieh/nancy/releases/tag/v0.1.7

We added a few builds as well, while doing that, mostly for 32 bit use.

cc @bhamail / @DarthHater / @zendern / @fitzoh

fitzoh · 2020-02-23T00:57:55Z

.circleci/config.yml

+    docker:
+      - image: circleci/golang:1.13
+        environment:
+          GO111MODULE: "on"


Is GO111MODULE: "on" still necessary for go 1.13?

The GO111MODULE environment variable continues to default to auto, but the auto setting now activates the module-aware mode of the go command whenever the current working directory contains, or is below a directory containing, a go.mod file — even if the current directory is within GOPATH/src. This change simplifies the migration of existing code within GOPATH/src and the ongoing maintenance of module-aware packages alongside non-module-aware importers.

https://golang.org/doc/go1.13#modules

I think I'm gonna leave it for now, but with Go 1.14 I don't mind removing it?

fitzoh · 2020-02-23T01:00:24Z

.circleci/config.yml

+          path: /tmp/test-results
+          destination: raw-test-output
+      - store_test_results:
+          path: /tmp/test-results


can/should you use TEST_RESULTS here?

I forgot why I did this, just kinda muscle memory at this point. CircleCI does not support an environment variable here, for some whatever reason!

fitzoh · 2020-02-23T01:07:03Z

.goreleaser.yml

+  algorithm: sha256
+
+snapshot:
+  name_template: "{{ .Tag }}-next-{{.FullCommit}}"


Does this pull in the previous tag value?

It pulls in the current tag value. The way GoReleaser works, is someone creates a tag, then CircleCI would start a build and release it. I preferred this a tiny bit to what we had before because it makes doing major and minor releases possible. Goreleaser also has a ton of functionality related to Docker, rpms, etc... that we could leverage.

.goreleaser.yml

zendern · 2020-02-23T20:09:49Z

README.md

@@ -5,6 +5,8 @@
    <a href="https://travis-ci.org/sonatype-nexus-community/nancy"><img src="https://travis-ci.org/sonatype-nexus-community/nancy.svg?branch=master" alt="Build Status"></img></a>


We should also cleanup travisci too.

I should have been clearer here..... :) we should also delete the .travis.yml as well :) No need to support both CI's.

zendern · 2020-02-23T20:24:25Z

I do have a concern when a test fails in CI currently it just shows nothing in output.

But maybe thats fine cause CircleCI has this tab?? Which maybe has more details when something fails?? #circleCiNewb

greut · 2020-02-24T06:55:31Z

.goreleaser.yml

+    ldflags:
+      - -s -w -X "github.com/sonatype-nexus-community/nancy/buildversion.BuildVersion={{.Version}}"
+      - -s -w -X "github.com/sonatype-nexus-community/nancy/buildversion.BuildTime={{time "2006-01-02T15:04:05Z07:00"}}"
+      - -s -w -X "github.com/sonatype-nexus-community/nancy/buildversion.BuildCommit={{.FullCommit}}"


The default value is a one liner, https://goreleaser.com/customization/#Builds

Suggested change

- -s -w -X "github.com/sonatype-nexus-community/nancy/buildversion.BuildCommit={{.FullCommit}}"

- >-

-s -w

-X "github.com/sonatype-nexus-community/nancy/buildversion.BuildVersion={{.Version}}"

-X "github.com/sonatype-nexus-community/nancy/buildversion.BuildTime={{time "2006-01-02T15:04:05Z07:00"}}"

-X "github.com/sonatype-nexus-community/nancy/buildversion.BuildCommit={{.FullCommit}}"

I'm not ANTI this, but I kinda like it as three separate commands (since it's doing it three different places). I don't have enough experience with goreleaser to know if one is preferable to the other. My main concern would be if one fails, etc...

The readability is I THINK easier with it broken out like this, is my main pro to having them the way I have it.

But yours isn't bad for that either (it's just clear on the original that it's running -s -w -X on all three, at a quick glance)

Co-Authored-By: Yoan Blanc <yoan@dosimple.ch>

DarthHater · 2020-02-24T19:02:50Z

@zendern here's an example with a failing test: https://app.circleci.com/jobs/github/sonatype-nexus-community/nancy/19

Also you can see the old experience here: https://circleci.com/gh/sonatype-nexus-community/nancy/19#tests/containers/0

Those steps I believe run no matter what to store artifacts/test results, so we should get the info all the time! You can see the details from the test failure in that tab.

An alternative would be to run go test ./... -v independently so it shows up in the build log, but I don't mind it being on the tests tab, personally.

DarthHater · 2020-02-25T18:55:18Z

@zendern @fitzoh @greut : we tested the goreleaser release on tag stuff on @allenhsieh 's fork: https://github.com/allenhsieh/nancy/releases/tag/v0.1.1 https://circleci.com/gh/allenhsieh/nancy/6

The only thing I noticed that I'm like EHHHH on is it's creating zips/tar.gz's so it adds a step to someone's download process. I think that's OK, but I wanted to run it past a few other people.

zendern · 2020-02-26T02:07:08Z

@DarthHater Looks good to me. We still need to update the README.md regarding install with tars being involved now and if I understand how it will work now it will no longer be on merge into master. It'll be when a tag is created so we should update that.

I do feel like we should probably bump it to 1.0.0. With this and #59 technically changing a public method signature (not sure if anyone is using it in that way) simply just changing to a minor version doesn't feel like enough since this is a breaking change there and in packaging.

DarthHater · 2020-02-26T21:10:56Z

@zendern @fitzoh @greut , we got it ALL figured out, and @allenhsieh just pushed up the changes to make it happen. If you'd like to approve/rubber stamp, now is a good time :)

DarthHater · 2020-02-27T01:53:35Z

I did!

…

On Wed, Feb 26, 2020 at 4:52 PM Nathan Zender ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In README.md <#80 (comment)> : > @@ -5,6 +5,8 @@ <a href="https://travis-ci.org/sonatype-nexus-community/nancy"><img src="https://travis-ci.org/sonatype-nexus-community/nancy.svg?branch=master" alt="Build Status"></img></a> I should have been clearer here..... :) we should also delete the .travis.yml as well :) No need to support both CI's. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#80?email_source=notifications&email_token=ABKJTBTIM5OWGNXGDGTCWE3RE4MHLA5CNFSM4KZU32JKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXDRCLA#discussion_r384872153>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKJTBRM6BVIVMUQQ5VF6R3RE4MHLANCNFSM4KZU32JA> .

zendern · 2020-02-27T01:55:56Z

I did!
…
On Wed, Feb 26, 2020 at 4:52 PM Nathan Zender @.> wrote: @.* commented on this pull request. ------------------------------ In README.md <#80 (comment)> : > @@ -5,6 +5,8 @@ <img](https://travis-ci.org/sonatype-nexus-community/nancy%22><img) src="https://travis-ci.org/sonatype-nexus-community/nancy.svg?branch=master" alt="Build Status"> I should have been clearer here..... :) we should also delete the .travis.yml as well :) No need to support both CI's. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#80?email_source=notifications&email_token=ABKJTBTIM5OWGNXGDGTCWE3RE4MHLA5CNFSM4KZU32JKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXDRCLA#discussion_r384872153>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKJTBRM6BVIVMUQQ5VF6R3RE4MHLANCNFSM4KZU32JA .

Current changelist looks like so :) maybe you forgot to push it??

zendern · 2020-02-27T01:57:08Z

@DarthHater do we also need this anymore?? https://github.com/sonatype-nexus-community/nancy/blob/master/bumpver.sh

DarthHater · 2020-02-27T01:58:17Z

Removed that and .travis.yml in 1861022 @zendern

DarthHater · 2020-02-27T01:59:04Z

And README.md looks good to me in: https://github.com/sonatype-nexus-community/nancy/pull/80/files#diff-04c6e90faac2675aa89e2176d2eec7d8R6-R7

DarthHater added 12 commits February 22, 2020 11:30

Let's give this a try

00cdab5

Badge

5a71700

Ok

7bcb7dc

Again

153723a

Filter

2f54363

gotestsum

8f31239

Tmp

f98da8f

Dogfood

add0b40

Goreleaser config

79c7ba1

RFC3339 time

3b243e4

Try this package out

8ed9ea6

Run em

30988a9

fitzoh reviewed Feb 23, 2020

View reviewed changes

greut reviewed Feb 23, 2020

View reviewed changes

.goreleaser.yml Show resolved Hide resolved

zendern reviewed Feb 23, 2020

View reviewed changes

greut reviewed Feb 24, 2020

View reviewed changes

DarthHater and others added 6 commits February 24, 2020 08:28

See if env works here

db10867

Update .goreleaser.yml

1076302

Co-Authored-By: Yoan Blanc <yoan@dosimple.ch>

Back to the known plus go mod tidy

27e4c3d

Get a bit more granular

b7e3e24

Hmmmm

1295f3a

Fail a test on purpose

acc5b4a

Remove this

f7f24fc

Remove requirement on build since build doesnt have a tag filter

9117a57

bringing over testing of GoReleaser code

eb500a2

DarthHater marked this pull request as ready for review February 26, 2020 22:10

DarthHater added 3 commits February 26, 2020 13:22

Update some README things

fe34d08

Merge branch 'master' into GoReleaser

f2eb293

LOL wut

2f8a78b

Remove

1861022

zendern approved these changes Feb 27, 2020

View reviewed changes

DarthHater merged commit c265fb0 into master Feb 27, 2020

DarthHater deleted the GoReleaser branch February 27, 2020 01:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GoReleaser #80

GoReleaser #80

DarthHater commented Feb 22, 2020 •

edited

Loading

fitzoh Feb 23, 2020

DarthHater Feb 26, 2020

fitzoh Feb 23, 2020

DarthHater Feb 24, 2020

fitzoh Feb 23, 2020

DarthHater Feb 24, 2020

zendern Feb 23, 2020

DarthHater Feb 26, 2020

zendern Feb 27, 2020

zendern commented Feb 23, 2020

greut Feb 24, 2020

DarthHater Feb 26, 2020

DarthHater Feb 26, 2020

DarthHater Feb 26, 2020

DarthHater commented Feb 24, 2020 •

edited

Loading

DarthHater commented Feb 25, 2020

zendern commented Feb 26, 2020

DarthHater commented Feb 26, 2020

DarthHater commented Feb 27, 2020 via email

zendern commented Feb 27, 2020

zendern commented Feb 27, 2020

DarthHater commented Feb 27, 2020

DarthHater commented Feb 27, 2020

		@@ -5,6 +5,8 @@
		<a href="https://travis-ci.org/sonatype-nexus-community/nancy"><img src="https://travis-ci.org/sonatype-nexus-community/nancy.svg?branch=master" alt="Build Status"></img></a>

GoReleaser #80

GoReleaser #80

Conversation

DarthHater commented Feb 22, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zendern commented Feb 23, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DarthHater commented Feb 24, 2020 • edited Loading

DarthHater commented Feb 25, 2020

zendern commented Feb 26, 2020

DarthHater commented Feb 26, 2020

DarthHater commented Feb 27, 2020 via email

zendern commented Feb 27, 2020

zendern commented Feb 27, 2020

DarthHater commented Feb 27, 2020

DarthHater commented Feb 27, 2020

DarthHater commented Feb 22, 2020 •

edited

Loading

DarthHater commented Feb 24, 2020 •

edited

Loading