-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid copying a lock by value, which is invalid. #59
Avoid copying a lock by value, which is invalid. #59
Conversation
Thanks for the contribution! Before we can merge this, we need @flimzy to sign the Sonatype Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the contribution looks good to me. @DarthHater @bhamail any thoughts??
Incidentally, I discovered this while debugging #58, thanks to running |
looks like
|
|
Well we are doing neither in CI and probably makes sense to do something there. @flimzy what if we open an issue, get a little feedback and see about adding at least @flimzy are you just running the default setup for ^^^I think the biggest thing with introducing that one is we just have to come to a little agreement what we do and don't want enabled. And really once we do it here it's probably going to get copied to other golang projects here like ahab. |
Makes sense to discuss in an issue, rather than here :)
I was using the default configuration. Although in most projects, I do use a custom config to enable a few non-default linters. |
We already fixed the 3 outstanding issues in sonatype-nexus-community#59 so once we merge that we can rebase this and get those all fixed up
We already fixed the 3 outstanding issues in sonatype-nexus-community#59 so once we merge that we can rebase this and get those all fixed up
We already fixed the 3 outstanding issues in sonatype-nexus-community#59 so once we merge that we can rebase this and get those all fixed up
We already fixed the 3 outstanding issues in sonatype-nexus-community#59 so once we merge that we can rebase this and get those all fixed up
It is not valid to copy a
sync.Mutex
value. From the docs:Doing so can lead to undefined results.
This PR fixes that, by passing a pointer to the value, rather than dereferencing the value before passing it.