Clean up dep artifacts from project root #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having this and go.mod at the root is confusing. We only left them to use for test. There are some in the testdata/dep directory so using those as part of CI to make sure it still works. That way new contributors can clearly look at the nancy project and know its using go mod.
DarthHater
approved these changes
Jan 3, 2020
There was a problem hiding this comment.
I think this is good to go @zendern , sorry I missed it, Holidays and all that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having this and go.mod at the root is confusing. We only left them to
use for test and have long since not had them used in the ci build but still tell people to build from source with them.
There are some in the testdata/dep directory so switches over to using those as part of CI to make sure dep integration still works.
This should make it so that new contributors can clearly look at the nancy project and know its using go mod.
It relates to the following issue #s:
Honestly this is what PR #12 was doing. I attempted to start on that one but the merge conflicts at this point were more of a pain to deal with than to just reimplement it based on a newer version of master.
cc @bhamail / @DarthHater