Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Go Modules #22

Closed
arschles opened this issue Aug 27, 2019 · 3 comments · Fixed by #67
Closed

switch to Go Modules #22

arschles opened this issue Aug 27, 2019 · 3 comments · Fixed by #67
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@arschles
Copy link

Thanks for creating an issue! Please fill out this form so we can be
sure to have all the information we need, and to minimize back and forth.

  • What are you trying to do?

Switch from using dep for dependency management to using Go Modules & a module proxy (i.e. GoNexus)

  • What feature or behavior is this required for?

Building the project

  • How could we solve this issue? (Not knowing is okay!)

Run go mod init to migrate from the dep config files, and then verify that the build still works and tests still pass

  • Anything else?

I'm happy to do this work, if folks are ok with the general idea

@DarthHater
Copy link
Member

DarthHater commented Aug 29, 2019

We pretty much already have (we use go mod to build Nancy on Travis CI, etc..)! We kept the Gopkg.lock file around mostly because when we started go mod was fairly new. If you want to send us a PR with that stuff gone/README updates, we'd love that, also if you want to use GoNexus on TravisCI, etc...!

Thanks for creating an issue ps!

@DarthHater
Copy link
Member

One of our team members pointed out that he did some (or maybe all) of this in #12 , wanna jump in there and +1 it, etc...?

@DarthHater DarthHater added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 12, 2019
@arschles
Copy link
Author

arschles commented Nov 7, 2019

@DarthHater sorry for the delay. Sure, I'll go +1 #12 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants