-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit purge #137
Exit purge #137
Conversation
I'm sure that you still are cranking, but when I run
|
re: this |
…ry NOT code on the weekend.
…s helpful message about where to look. Other cleanups from PR feedback.
no objections, and some implicit approval, so merging this puppy in a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THIS STAMP IS RUBBER AND I GIVE IT TO YOU, FREE OF CHARGE
CAPS LOCK FRIDAY! |
Minimize places where we call os.Exit(), in preparation for conversion to using Cobra #134
I think this is ready for review.
I was a little concerned about the CI build failing in the logger_test.go. Seemed to be an unrelated change. Rerunning the CI build and it just passed. Boggle. We should keep an eye out in case this is a heisenbug.
BTW, we may have a decision point regarding "--command, -flag" syntax in the near future.
Fixes #78
cc @bhamail / @DarthHater