Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nancy not so exit heavy #78

Closed
zendern opened this issue Feb 22, 2020 · 3 comments · Fixed by #137
Closed

Make nancy not so exit heavy #78

zendern opened this issue Feb 22, 2020 · 3 comments · Fixed by #137
Assignees

Comments

@zendern
Copy link
Contributor

zendern commented Feb 22, 2020

For now the exits have been put back in place instead of using a panic which made testing easier to do.

General go guidance is as follows, so this is where we should start to move the codebase.

The convention in the Go libraries is that even when a package uses panic internally, its external API still presents explicit error return values.
  • What feature or behavior is this required for?
    No real feature just more of a tech debt/cleanup/make it better type thing.

  • How could we solve this issue? (Not knowing is okay!)
    Stop exiting so much and panic instead but at the same time we still will want to preserve the exit codes and the user friendly messages after this change. No stack trace should be presented to the user.

  • Anything else?
    ¯_(ツ)_/¯

cc @bhamail / @DarthHater

@DarthHater
Copy link
Member

@bhamail good issue to tack on to for #134

@bhamail
Copy link
Contributor

bhamail commented Apr 17, 2020

@DarthHater Agreed. Will do

This was referenced Apr 17, 2020
@bhamail bhamail self-assigned this Apr 18, 2020
@bhamail
Copy link
Contributor

bhamail commented Apr 18, 2020

Working on this here: #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants