You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For now the exits have been put back in place instead of using a panic which made testing easier to do.
General go guidance is as follows, so this is where we should start to move the codebase.
The convention in the Go libraries is that even when a package uses panic internally, its external API still presents explicit error return values.
What feature or behavior is this required for?
No real feature just more of a tech debt/cleanup/make it better type thing.
How could we solve this issue? (Not knowing is okay!)
Stop exiting so much and panic instead but at the same time we still will want to preserve the exit codes and the user friendly messages after this change. No stack trace should be presented to the user.
As part of Nancy uses Nexus IQ Server, the journey #68 @DarthHater was trying to do some testing and it the fact that Nancy exits like its going out of style made it overly difficult.
For now the exits have been put back in place instead of using a panic which made testing easier to do.
General go guidance is as follows, so this is where we should start to move the codebase.
What feature or behavior is this required for?
No real feature just more of a tech debt/cleanup/make it better type thing.
How could we solve this issue? (Not knowing is okay!)
Stop exiting so much and panic instead but at the same time we still will want to preserve the exit codes and the user friendly messages after this change. No stack trace should be presented to the user.
Anything else?
¯_(ツ)_/¯
cc @bhamail / @DarthHater
The text was updated successfully, but these errors were encountered: