Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent Proxy namespace from being modified #9635

Merged
merged 2 commits into from
Jun 17, 2024
Merged

prevent Proxy namespace from being modified #9635

merged 2 commits into from
Jun 17, 2024

Commits on Jun 17, 2024

  1. prevent Proxy namespace from being modified (#9629) 

    Previously, a 'metaKey' was generated for each Proxy being translated
and synced to envoy. This key was used as a 'tag' for tracing of the
translation/sync prcoess. It used a custom function that was almost exactly
matched how the SnapshotCacheKey used for xDS was generated; this function
also modified the actual Proxy's namespace, which broke assumptions of where
the proxy lives in the in-memory client.

By removing the namespace modification we fix various status error logs as
now the Proxy is located where the rest of the system expects (the write
namespace). Also, we can simply use the SnapshotCacheKey(...) to generate
a key with the same logic used for xds.
    @lgadban
    lgadban committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    bb9864b View commit details
    Browse the repository at this point in the history

  2. move changelogs

    @lgadban
    lgadban committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    0f3100f View commit details
    Browse the repository at this point in the history