prevent Proxy namespace from being modified #9635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a 'metaKey' was generated for each Proxy being translated and synced to envoy. This key was used as a 'tag' for tracing of the translation/sync prcoess. It used a custom function that was almost exactly matched how the SnapshotCacheKey used for xDS was generated; this function also modified the actual Proxy's namespace, which broke assumptions of where the proxy lives in the in-memory client. By removing the namespace modification we fix various status error logs as now the Proxy is located where the rest of the system expects (the write namespace). Also, we can simply use the SnapshotCacheKey(...) to generate a key with the same logic used for xds.
|
Issues linked to changelog: |
github-actions
bot
added
the
keep pr updated
jenshu
approved these changes
Jun 17, 2024
npolshakova
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #9629
BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/6252