feat: Expose initial_metadata in GrpcHealthCheck #8511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
keep pr updated
davidjumani
force-pushed
the
expose-initialmetadata-grpchealthcheck
branch
from
a78bd04
to
a626dc8
Compare
davidjumani
force-pushed
the
expose-initialmetadata-grpchealthcheck
branch
from
171d379
to
009db75
Compare
|
Issues linked to changelog: |
nfuden
reviewed
Jul 28, 2023
projects/gloo/api/external/envoy/api/v2/core/health_check.proto
Outdated
Show resolved
Hide resolved
davidjumani
commented
Jul 28, 2023
| // Specifies a list of key-value pairs that should be added to the metadata of each GRPC call | ||
| // that is sent to the health checked cluster. | ||
| repeated .solo.io.envoy.api.v2.core.HeaderValueOption initial_metadata = 3 | ||
| [(validate.rules).repeated .max_items = 1000]; |
There was a problem hiding this comment.
Similar to http health check
https://github.com/solo-io/gloo/blob/main/projects/gloo/api/external/envoy/api/v2/core/health_check.proto#L122
davidjumani
commented
Jul 28, 2023
|
Visit the preview URL for this PR (updated for commit 78932d2): https://gloo-edge--pr8511-expose-initialmetada-8qa4vxzw.web.app (expires Mon, 07 Aug 2023 19:22:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io>
nfuden
reviewed
Jul 28, 2023
elcasteel
reviewed
Jul 31, 2023
davidjumani
force-pushed
the
expose-initialmetadata-grpchealthcheck
branch
from
47ed3cd
to
78932d2
Compare
elcasteel
approved these changes
Jul 31, 2023
nfuden
approved these changes
Aug 1, 2023
davidjumani
added a commit
that referenced
this pull request
Aug 1, 2023
* feat: Expose initial_metadata in GrpcHealthCheck * Trigger CI * Fix uneven whitespace Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> * Adding changelog file to new location * Avoid code duplcation * Removing duplicate changelog * fix test * Add check for forbidden custom headers --------- Co-authored-by: David Jumani <djumani@Solo-System-DJumani.local> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> Co-authored-by: changelog-bot <changelog-bot>
4 tasks
soloio-bulldozer bot
added a commit
that referenced
this pull request
Aug 1, 2023
* feat: Expose initial_metadata in GrpcHealthCheck (#8511) * feat: Expose initial_metadata in GrpcHealthCheck * Trigger CI * Fix uneven whitespace Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> * Adding changelog file to new location * Avoid code duplcation * Removing duplicate changelog * fix test * Add check for forbidden custom headers --------- Co-authored-by: David Jumani <djumani@Solo-System-DJumani.local> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> Co-authored-by: changelog-bot <changelog-bot> * Move changelog * Update changelog --------- Co-authored-by: David Jumani <djumani@Solo-System-DJumani.local> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposes the
initial_metadatafield inGrpcHealthCheckContext
#8490
Checklist:
make -B install-go-tools generated-codeto ensure there will be no code diffBOT NOTES:
resolves #8490