Skip to content

Commit

Permalink
Refactor
Browse files Browse the repository at this point in the history
  • Loading branch information
David Jumani authored and David Jumani committed Jul 27, 2023
1 parent 22bb98c commit a78bd04
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions pkg/utils/api_conversion/health_check.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,15 +161,15 @@ func ToEnvoyHealthCheck(check *envoycore_gloo.HealthCheck, secrets *v1.SecretLis
}

case *envoycore_gloo.HealthCheck_GrpcHealthCheck_:
var initialMetadataToAdd, err = ToEnvoyHeaderValueOptionList(typed.GrpcHealthCheck.GetInitialMetadata(), secrets)
var initialMetadata, err = ToEnvoyHeaderValueOptionList(typed.GrpcHealthCheck.GetInitialMetadata(), secrets)
if err != nil {
return nil, err
}
hc.HealthChecker = &envoy_config_core_v3.HealthCheck_GrpcHealthCheck_{
GrpcHealthCheck: &envoy_config_core_v3.HealthCheck_GrpcHealthCheck{
ServiceName: typed.GrpcHealthCheck.GetServiceName(),
Authority: typed.GrpcHealthCheck.GetAuthority(),
InitialMetadata: initialMetadataToAdd,
InitialMetadata: initialMetadata,
},
}
case *envoycore_gloo.HealthCheck_CustomHealthCheck_:
Expand Down Expand Up @@ -258,8 +258,9 @@ func ToGlooHealthCheck(check *envoy_config_core_v3.HealthCheck) (*envoycore_gloo
case *envoy_config_core_v3.HealthCheck_GrpcHealthCheck_:
hc.HealthChecker = &envoycore_gloo.HealthCheck_GrpcHealthCheck_{
GrpcHealthCheck: &envoycore_gloo.HealthCheck_GrpcHealthCheck{
ServiceName: typed.GrpcHealthCheck.GetServiceName(),
Authority: typed.GrpcHealthCheck.GetAuthority(),
ServiceName: typed.GrpcHealthCheck.GetServiceName(),
Authority: typed.GrpcHealthCheck.GetAuthority(),
InitialMetadata: ToGlooHeaderValueOptionList(typed.GrpcHealthCheck.GetInitialMetadata()),
},
}
case *envoy_config_core_v3.HealthCheck_CustomHealthCheck_:
Expand Down

0 comments on commit a78bd04

Please sign in to comment.