Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose statsconfig tags 1.14 #8459

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Conversation

jenshu
Copy link
Contributor

@jenshu jenshu commented Jul 12, 2023

backport #8333
BOT NOTES:
resolves #5537

jlourenc and others added 2 commits July 12, 2023 08:13
* feat: expose Envoy statistics configuration in gwp

Allows configuring Envoy stats_config propety in Gateway Proxy.

* Update install/helm/gloo/generate/values.go

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

* changelog and update docs

* Update gwp-stats-config.yaml

---------

Co-authored-by: Seth Heidkamp <61526534+sheidkamp@users.noreply.github.com>
Co-authored-by: Rachael Graham <rachael.graham@solo.io>
Co-authored-by: sheidkamp <seth.heidkamp@gmail.com>
@jenshu jenshu requested a review from a team as a code owner July 12, 2023 12:14
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jul 12, 2023
sam-heilbron
sam-heilbron previously approved these changes Jul 12, 2023
Copy link
Contributor

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I nit on the changelog, but I see it mirrors the original PR. Thanks for taking care of this!

@@ -0,0 +1,4 @@
changelog:
- type: NON_USER_FACING
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Helm since we're adding a new value?

@solo-changelog-bot
Copy link

Issues linked to changelog:
#5537

@soloio-bulldozer soloio-bulldozer bot merged commit a4e96ea into v1.14.x Jul 12, 2023
12 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the expose-statsconfig-tags-1.14 branch July 12, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants