-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose statsconfig tags 1.14 #8459
Conversation
* feat: expose Envoy statistics configuration in gwp Allows configuring Envoy stats_config propety in Gateway Proxy. * Update install/helm/gloo/generate/values.go Co-authored-by: Rachael Graham <rachael.graham@solo.io> * changelog and update docs * Update gwp-stats-config.yaml --------- Co-authored-by: Seth Heidkamp <61526534+sheidkamp@users.noreply.github.com> Co-authored-by: Rachael Graham <rachael.graham@solo.io> Co-authored-by: sheidkamp <seth.heidkamp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I nit on the changelog, but I see it mirrors the original PR. Thanks for taking care of this!
@@ -0,0 +1,4 @@ | |||
changelog: | |||
- type: NON_USER_FACING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be Helm since we're adding a new value?
Issues linked to changelog: |
backport #8333
BOT NOTES:
resolves #5537