feat: expose stats tags in gateway-proxy stats config #8333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for approval from someone in the solo-io org to start testing. |
jlourenc
force-pushed
the
expose-statsconfig-tags
branch
2 times, most recently
from
90177b9
to
b5b9356
Compare
sam-heilbron
reviewed
Jun 2, 2023
There was a problem hiding this comment.
Thanks for the contribution @jlourenc!
I like the idea here, there are just a few changes that we'll need to make:
- https://github.com/solo-io/gloo/blob/main/install/helm/gloo/generate/values.go is the source of truth for our helm docs. If you update the configuration you want to modify, and then run code-generation, the helm reference docs will be dynamically updated
- For any helm changes, we use https://github.com/solo-io/gloo/blob/main/install/test/helm_test.go to write a unit test to assert that the generated manifests match what we would expect. https://github.com/solo-io/gloo/blob/main/install/test/helm_test.go#L3607 is an example of a test that will be similar to yours (ie we apply some values, render the manifests, and assert the existence of the injected configuration)
- Have you explored https://docs.solo.io/gloo-edge/latest/reference/helm_chart_values/open_source_helm_chart_values/#helm-chart-kuberesourceoverrides? We expose a way to inject custom values to a lot of our templates, and perhaps you can use this to define the stats configuration generically (without being blocked by this helm change)
jlourenc
force-pushed
the
expose-statsconfig-tags
branch
2 times, most recently
from
c86859d
to
d78cc8a
Compare
|
Hey @sam-heilbron , thanks for taking a look.
|
jlourenc
force-pushed
the
expose-statsconfig-tags
branch
from
d78cc8a
to
cea84bb
Compare
|
/test |
jlourenc
force-pushed
the
expose-statsconfig-tags
branch
from
cea84bb
to
55dd295
Compare
sheidkamp
reviewed
Jun 30, 2023
sheidkamp
reviewed
Jun 30, 2023
sheidkamp
reviewed
Jun 30, 2023
sheidkamp
reviewed
Jun 30, 2023
jlourenc
force-pushed
the
expose-statsconfig-tags
branch
from
41633fa
to
83d7463
Compare
Allows configuring Envoy stats_config propety in Gateway Proxy.
jlourenc
force-pushed
the
expose-statsconfig-tags
branch
from
83d7463
to
1f485f6
Compare
|
I have taken your suggestions onboard to update the test. Please take another look 🙏🏼 |
sheidkamp
previously approved these changes
Jul 5, 2023
elcasteel
previously approved these changes
Jul 5, 2023
|
/test run build-bot |
Co-authored-by: Rachael Graham <rachael.graham@solo.io>
|
/kick not sure what's hung up |
|
/test run build-bot |
sheidkamp
previously approved these changes
Jul 5, 2023
elcasteel
previously approved these changes
Jul 5, 2023
sheidkamp
approved these changes
Jul 5, 2023
elcasteel
approved these changes
Jul 5, 2023
|
/test rerun build bot with new changes |
jenshu
pushed a commit
that referenced
this pull request
Jul 12, 2023
* feat: expose Envoy statistics configuration in gwp Allows configuring Envoy stats_config propety in Gateway Proxy. * Update install/helm/gloo/generate/values.go Co-authored-by: Rachael Graham <rachael.graham@solo.io> * changelog and update docs * Update gwp-stats-config.yaml --------- Co-authored-by: Seth Heidkamp <61526534+sheidkamp@users.noreply.github.com> Co-authored-by: Rachael Graham <rachael.graham@solo.io> Co-authored-by: sheidkamp <seth.heidkamp@gmail.com>
This was referenced Jul 12, 2023
soloio-bulldozer bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
* feat: expose stats tags in gateway-proxy stats config (#8333) * feat: expose Envoy statistics configuration in gwp Allows configuring Envoy stats_config propety in Gateway Proxy. * Update install/helm/gloo/generate/values.go Co-authored-by: Rachael Graham <rachael.graham@solo.io> * changelog and update docs * Update gwp-stats-config.yaml --------- Co-authored-by: Seth Heidkamp <61526534+sheidkamp@users.noreply.github.com> Co-authored-by: Rachael Graham <rachael.graham@solo.io> Co-authored-by: sheidkamp <seth.heidkamp@gmail.com> * move cl * Update gwp-stats-config.yaml * Update gwp-stats-config.yaml --------- Co-authored-by: Jérémy Lourenço <jeremy.lourenco@snyk.io> Co-authored-by: Seth Heidkamp <61526534+sheidkamp@users.noreply.github.com> Co-authored-by: Rachael Graham <rachael.graham@solo.io> Co-authored-by: sheidkamp <seth.heidkamp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This new feature can be used to configure gateway proxies stats configuration with stats tags.
Checklist:
make -B install-go-tools generated-codeto ensure there will be no code diff