Fix yaml separation for ssl default gw #8406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for approval from someone in the solo-io org to start testing. |
|
/test |
There was a problem hiding this comment.
Thanks for the contribution @mtenrero! I see that this is the only instance of this case in our codebase. Can you add a test case that would fail without this change? It would help us to have this test to avoid people adding regressions to this.
Also, we tend to introduce code first to the main branch, and then backport those changes to our long term support branches after it has been merged into our stable (main) branch. Could you direct this PR to main?
|
@mtenrero I am going to close this PR now due to inactivity. If you have time to add a test case, please feel free to reopen it and I will be happy to review it again. Thanks! |
This was referenced Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes YAML separation characters for SSL default gateways
#8404
Context
When setting SSL Default Gateways with Helm bad line break placements broke the ssl gateway creation