Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating several GatewayProxies with Helm doesn't generate SSL Gateways #8404

Closed
mtenrero opened this issue Jun 20, 2023 · 1 comment
Closed
Assignees
Labels
Type: Bug Something isn't working

Comments

@mtenrero
Copy link

Gloo Edge Version

1.14.x (latest stable)

Kubernetes Version

1.24.x

Describe the bug

Due an error in the Helm template, when defining GatewayProxies with SSL support, those are not properly generated in some scenarios:

---
    apiVersion: gateway.solo.io/v1
    kind: Gateway
    metadata:
      name: default
      namespace: default
      labels:
        app: gloo
    spec:
      bindAddress: "::"
      bindPort: 8080
      httpGateway:
        virtualServiceSelector:
          gateway-type: default
      useProxyProto: false
      ssl: false
      proxyNames:
      - default
    ---
    apiVersion: gateway.solo.io/v1
    kind: Gateway
    metadata:
      name: default-ssl
      namespace: default
      labels:
        app: gloo
    spec:
      bindAddress: "::"
      bindPort: 8443
      httpGateway:
        virtualServiceSelector:
          gateway-type: default
      useProxyProto: false
      ssl: true
      proxyNames:
      - default---

Steps to reproduce the bug

  1. Define several Gateway Proxies in Helm values
  2. Install/Template Chart
  3. SSL Gateways are not generated due to a missing newline char

Expected Behavior

SSL Gateways should be correctly generated

Additional Context

No response

@jenshu
Copy link
Contributor

jenshu commented Jul 25, 2023

fix will be available in Gloo OSS v1.15.0-beta23, v1.14.13, and v1.13.23

@jenshu jenshu closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants