Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update es-MX locale #129

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Update es-MX locale #129

merged 1 commit into from
Jan 29, 2019

Conversation

jtapia
Copy link
Contributor

@jtapia jtapia commented Jun 13, 2018

No description provided.

@jtapia jtapia force-pushed the chore/es-mx-locale branch from 43ad53f to 9489956 Compare June 13, 2018 18:18
@jtapia jtapia mentioned this pull request Jun 13, 2018
Closed
tvdeyen
tvdeyen requested changes Jun 13, 2018
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO all words should be capitalized

config/locales/es-MX.yml Outdated Show resolved Hide resolved
config/locales/es-MX.yml Outdated Show resolved Hide resolved
@jtapia jtapia force-pushed the chore/es-mx-locale branch from 9489956 to f615a11 Compare June 13, 2018 19:15
tvdeyen
tvdeyen approved these changes Jun 13, 2018
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

@jtapia jtapia force-pushed the chore/es-mx-locale branch from f615a11 to fc9d293 Compare June 13, 2018 19:20
coorasse
coorasse requested changes Jan 29, 2019
View reviewed changes
Copy link
Collaborator

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove the date block in translations since is already provided by rails-i18n

config/locales/es-MX.yml Outdated Show resolved Hide resolved
@jtapia jtapia force-pushed the chore/es-mx-locale branch from fc9d293 to 449c010 Compare January 29, 2019 20:37
coorasse
coorasse approved these changes Jan 29, 2019
View reviewed changes
Copy link
Collaborator

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@coorasse coorasse merged commit c59c9e5 into solidusio:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coorasse coorasse coorasse approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtapia @tvdeyen @coorasse