Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not update available on date #2721

Closed
sechix opened this issue May 1, 2018 · 6 comments · Fixed by #3321
Closed

Not update available on date #2721

sechix opened this issue May 1, 2018 · 6 comments · Fixed by #3321
Labels
changelog:solidus_backend Changes to the solidus_backend gem confirmed Validated report type:bug Error, flaw or fault

Comments

@sechix
Copy link

sechix commented May 1, 2018

Steps to reproduce

In products show a different date in input datapicker field that in database
image

System configuration

Solidus Master last version

@jacobherrington
Copy link
Contributor

Hey @sechix I can't replicate this issue, it seems to be working for me.

If you hit update at the bottom of the product page, does your database match?

Could you post some reproduction steps?

Thanks!

@sechix
Copy link
Author

sechix commented Jun 11, 2018

image

Update product:
image

After update (even refreshing page):

image

image

@jtapia
Copy link
Contributor

jtapia commented Jun 13, 2018

with es-MX you can see this:
screen shot 2018-06-13 at 11 40 43 am

and later I got a missing translation error, I created this PR solidusio/solidus_i18n#129 to fix that, with es, es-EC and es-CL is working fine

@sechix what is the locale that are you using?

@Draiken
Copy link
Contributor

Draiken commented Oct 1, 2018

I have the same issue. Seems to be related to localization since I use pt-BR and have the exact same issue. My guess is that the datepicker format has a specific format and i18n changes the default date formats, causing the disconnect between the actual value from the input and the datepicker's display

@Draiken
Copy link
Contributor

Draiken commented Oct 1, 2018

This line shows how the datepicker format uses i18n to decide the datepicker format. This seems wrong to me, as I imagine the datepicker will always accept one specific format, so it should be hard coded.

@Draiken
Copy link
Contributor

Draiken commented Oct 1, 2018

To expand a bit: on the context of solidus_i18n you see a field called spree.date_picker.format and it makes sense to localize that to the local format. However by doing that you break the datepickers on the admin (haven't tested others, but I imagine everywhere that this helper is used will give the same result).

I propose we hard-code the datepicker format to something that always works, since this is not a presentational value but instead a value that is used by a third party library.

@jacobherrington jacobherrington added changelog:solidus_backend Changes to the solidus_backend gem UI confirmed Validated report labels Nov 21, 2018
@waiting-for-dev waiting-for-dev added the type:bug Error, flaw or fault label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem confirmed Validated report type:bug Error, flaw or fault
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants