This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
Update duktape to 1.4.0 release #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 19, 2016 17:42
They now provide a src-noline/ dir with the sources where there are no "#line" cpp directives. This way we stop preventing our js module packaging to provide debugging symbols on RPM (and other) packages. Signed-off-by: Gustavo Lima Chaves <gustavo.lima.chaves@intel.com>
Signed-off-by: Gustavo Lima Chaves <gustavo.lima.chaves@intel.com>
This was referenced Feb 19, 2016
Closed
|
@cabelitos, @bdilly ^ good enough? |
|
@glima fine by me. But you tested our node types / samples with this version, right? |
|
I did. Now merging, then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will solve the issues with packaging (and also having valid debug symbols for this part of the code) and the "#line" directive used before. From this release on, they ship a "src-noline" version of the sources, that we now use. I tested our samples with this new code and we're fine. We have some new build warnings, thought (on duktape), that I'll fix in the sequence.