Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Lines #3

Closed
wants to merge 2 commits into from
Closed

Lines #3

wants to merge 2 commits into from

Conversation

glima
Copy link

@glima glima commented Sep 16, 2015

While packaging Soletta, I noticed that these #line entries fsck big time generating sane debug packages for the js module. This fixes that.

Gustavo Lima Chaves added 2 commits September 16, 2015 16:25
This way we stop preventing our js module packaging to provide
right debugging symbols.

Signed-off-by: Gustavo Lima Chaves <gustavo.lima.chaves@intel.com>
Signed-off-by: Gustavo Lima Chaves <gustavo.lima.chaves@intel.com>
@bdilly
Copy link
Contributor

bdilly commented Sep 16, 2015

Honestly I don't like much the idea of changing duktape code in this repository. What are these lines used for?
If unnecessary, a patch could be sent upstream, right?
But if they aren't accepting for stupid reasons I'm ok with this approach.

@glima
Copy link
Author

glima commented Sep 16, 2015

I have no idea why they leave these leftovers on the amalgamated file, I guess it's a bug. Ok, I'll try to contact them upstream at some point.

@glima
Copy link
Author

glima commented Sep 18, 2015

Upstream devs of duktape have been contacted WRT this and it seems we're getting a release (1.4.0) addressing this. Soon...

@glima
Copy link
Author

glima commented Sep 22, 2015

svaarala/duktape#362 and svaarala/duktape#363 are happening, for the record.

@glima
Copy link
Author

glima commented Nov 4, 2015

svaarala/duktape#363 got merged. As soon as they have the next release, I'll update on Soletta's side.

@glima
Copy link
Author

glima commented Nov 30, 2015

Just as a tip, that release should be 1.4.0 (not issued yet).

@glima
Copy link
Author

glima commented Feb 19, 2016

#4 is the new PR for this, closing.

@glima glima closed this Feb 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants