NH-34752 Update span layer, little refactor #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleverchuk
approved these changes
Apr 19, 2023
raphael-theriault-swi
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Python APM-produced span layers to be
<KIND>:<NAME>and match what Java APM does. This is a prerequisite for implementing transaction filtering.Example trace before this update uses these span layers:
home_a/home_b/HTTP GETmanual_instrumentation_django_amanual_instrumentation_django_bpostgresqlsqliteExample trace after this update uses:
SERVER:home_a/SERVER:home_b/CLIENT:HTTP GETINTERNAL:manual_instrumentation_django_aINTERNAL:manual_instrumentation_django_bpostgresqlsqlite6 and 7 are expected as per improvements based on mrQ's requests (see also Slack thread).
This PR also does a little refactor of config file reading based on this PR comment.
Please let me know if any questions/suggestions!