NH-34752 Add config JSON file support #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| val = cnf_dict.get("transaction").get("prependDomain") | ||
| if val is not None: | ||
| self._set_config_value("transaction.prepend_domain_name", val) | ||
| except AttributeError: |
Check notice
Code scanning / CodeQL
Empty except
raphael-theriault-swi
approved these changes
Apr 17, 2023
| # TODO after alpha: is_lambda | ||
| for key in available_cnf: | ||
| cnf_key_parts = key.split("_") | ||
| cnf = f"{cnf_key_parts[0]}{''.join(part.title() for part in cnf_key_parts[1:])}" |
There was a problem hiding this comment.
Just to make sure I understand this goes from snake_case to camelCase ?
There was a problem hiding this comment.
Maybe worth extracting to a function in a future revision to make it more evident at first glance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the stub for
update_with_cnf_fileand adds a helperupdate_transaction_filters. Both read values from a customer file atSW_APM_CONFIG_FILEelse the default./solarwinds-apm-config.json, to copy what Java APM does. Values are stored in theSolarWindsApmConfiginit'd by Configurator and passed to our custom Otel components at service startup.The config file JSON keys are a bit different than Java. Example:
triggerTraceSW_APM_TRIGGER_TRACEAll thoughts/questions welcome!
Next PRs:
transaction_filtersatshould_sample