This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance metrics computation methodology #4041
Performance metrics computation methodology #4041
Changes from 1 commit
bf8976e
5106141
643a19a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s not correct. The validator confirmation time for a fork is based on the difference when a fork is created and when the first child fork that has a cumulative supermajority vote for the original fork s frozen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that fork is frozen when there's a cumulative supermajority vote. I don't understand why the child fork has to be frozen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frozen right now means that blocktree received all the blobs and the bank processed them. Validator confirmation time for a parent is based on when any descendant of the parent is frozen and that branch has a supermajority conforming the parent. Replay stage doesn’t compute a rolling vote total on incomplete forks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. that makes sense. I had interpreted your last comment as one of the child fork has to receive supermajority vote. Just to confirm, this is when a fork is considered confirmed: