Performance metrics computation methodology #4041
Conversation
book/src/performance-metrics.md
Outdated
| ## Confimation Time | ||
|
|
||
| Each validator node maintains a list of active ledger forks that are visible | ||
| to the node. Whenever a fork's final tick is registered, the fork is frozen, and |
There was a problem hiding this comment.
That’s not correct. The validator confirmation time for a fork is based on the difference when a fork is created and when the first child fork that has a cumulative supermajority vote for the original fork s frozen.
There was a problem hiding this comment.
I understand that fork is frozen when there's a cumulative supermajority vote. I don't understand why the child fork has to be frozen?
There was a problem hiding this comment.
Frozen right now means that blocktree received all the blobs and the bank processed them. Validator confirmation time for a parent is based on when any descendant of the parent is frozen and that branch has a supermajority conforming the parent. Replay stage doesn’t compute a rolling vote total on incomplete forks.
There was a problem hiding this comment.
ok. that makes sense. I had interpreted your last comment as one of the child fork has to receive supermajority vote. Just to confirm, this is when a fork is considered confirmed:
- The fork itself has received cumulative supermajority vote.
- One of the child of the fork has been frozen (i.e. received all it's blocks)
* Define BankingTracer::create_channels() * Make create_channels() take a bool
Problem
No metrics methodology document
Summary of Changes
Added the document.
Fixes #3864