clippy 0.1.70: 2023-03-18: Apply suggestions, disable false positives

[ilya-bobyr]

Problem

Clippy does not like a few things in the current master

Summary of Changes

Apply suggestions, and disable a few false positives with an explanatory comment.

[codecov]

Codecov Report

Merging #30808 (79c6840) into master (f4cde7a) will not change coverage.
The diff coverage is 18.4%.

@@           Coverage Diff           @@
##           master   #30808   +/-   ##
=======================================
  Coverage    81.4%    81.4%           
=======================================
  Files         725      725           
  Lines      203465   203465           
=======================================
  Hits       165740   165740           
  Misses      37725    37725           

[ilya-bobyr]

I can split this into multiple PRs – one per package, if anyone thinks it would simplify the review process.

[CriesofCarrots]

Can you please add to the problem statement details about why we care about lints from this particular version of nightly? (Also, see #30664 for discussion about which nightly the monorepo will adopt with rust v1.68)

[ilya-bobyr]

Can you please add to the problem statement details about why we care about lints from this particular version of nightly? (Also, see #30664 for discussion about which nightly the monorepo will adopt with rust v1.68)

My bad. I should have checked the specific version of nightly that we use.
Seems like nor beta (which is currently 1.69.0-beta3) nor the nightly that we use (nightly-2023-02-08) show any warnings, unlike the actual nightly.

3 rules are triggered:

• redundant_async_block, marked as active starting in 1.69.
• match_result_ok, added in 1.57.
• redundant_clone, added in 1.32.

I wonder if the last 2 got improved in the nightly version of Clippy.
As, it does point to cases that match second and third rules in our codebase.

If we do not want to deal with this for now, I can probably just close it.

[CriesofCarrots]

If we do not want to deal with this for now, I can probably just close it.

We tend to do these sorts of fixes in one fell swoop when we upgrade the version of rust on the master branch, which means we can usually avoid transient nightly warnings.

We could move forward with these changes, minus all the comments about redundant_async_block, as minor cleanup, but I'd also be fine with punting until we upgrade to rust v1.69

[ilya-bobyr]

If we do not want to deal with this for now, I can probably just close it.

We tend to do these sorts of fixes in one fell swoop when we upgrade the version of rust on the master branch, which means we can usually avoid transient nightly warnings.

Makes sense.

We could move forward with these changes, minus all the comments about redundant_async_block, as minor cleanup, but I'd also be fine with punting until we upgrade to rust v1.69

I'll just close it for now. Sorry for the noise.
And thank you for looking into it so quickly!