Upgrades Rust to 1.68.0

[brooksprumo]

...and upgrades nightly Rust to 1.70.0-nightly 1.69.0-nightly.

Release notes: https://releases.rs/docs/1.68.0/

[brooksprumo]

@yihau Can I request a new CI rust image with stable = 1.68.0 and nightly = 2023-03-09? Thank you! 👻

[yihau]

anytime! just uploaded and retried the pipeline 👻

btw, I'm investigating the coverage error

updated:
✅ rust version 1.69.0-nightly (bd39bbb4b 2023-02-07)
❌ rust version 1.69.0-nightly (ef934d9b6 2023-02-08)
^^^ coverage test with sccache is broken from this version 😢 will dig deeper

[ryoqun]

hi, i appreciate your work of latest rustc updates. :) fyi, #30602 make clippy complain sbf code newly, unlike previously. so, i think this needs rebase to avoid post-merge ci failure.

[ryoqun]

also, as it's nightly (a bit buggy), using slightly newer or older day's build might fix the coverage issue. (didn't see in depth)

[brooksprumo]

also, as it's nightly (a bit buggy), using slightly newer or older day's build might fix the coverage issue. (didn't see in depth)

Ah gotcha, that's a good thing to note. @yihau, would you like me to try a different version of nightly?

[yihau]

forgot to update here haha. I sent an issue to sccache mozilla/sccache#1652

[brooksprumo]

@yihau I'm inclined to change the nightly rust version in this PR to workaround the sccache issue. Does that work for you?

Also, which version is the highest working version? Over here you say 2023-02-08, and here you say 2023-02-07.

[yihau]

oh! it will be great! I'm worrying about how to turn off sccache for coverage test 🙈
The latest workable version is nightly-2023-02-08 [rustc 1.69.0-nightly (bd39bbb4b 2023-02-07)]

[brooksprumo]

The latest workable version is nightly-2023-02-08 [rustc 1.69.0-nightly (bd39bbb4b 2023-02-07)]

Done! Nightly rust set to 2023-02-08. Does this need a new CI image, or will it be ok?

[yihau]

just uploaded the image and retried the pipeline!

[codecov]

Codecov Report

Merging #30664 (617c378) into master (7f58345) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #30664     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         723      723             
  Lines      201621   200393   -1228     
=========================================
- Hits       164681   163637   -1044     
+ Misses      36940    36756    -184     

[brooksprumo]

/me nudges @mvines

Or if it's OK, I can ask others to review too 🙏

[mvines]

/me nudges @mvines

Or if it's OK, I can ask others to review too 🙏

Sounds like good practice for somebody else to review, so I'm never the bottleneck

[brooksprumo]

@ilya-bobyr @ryoqun I've added y'all as reviewers here, since you are top-of-mind when I think of rustaceans.

I do see that 1.68.1 was just release too; I'd rather that be handled in a subsequent PR to not have to go through CI again here, heh, but maybe I should (seems to only impact Windows though)?. Thanks in advance, and let me know if I can help with any additional info/context.

[ilya-bobyr]

@ilya-bobyr @ryoqun I've added y'all as reviewers here, since you are top-of-mind when I think of rustaceans.

The update seems trivial - no code changes :)
And if the CI is passing, is there anything else to check?

I do see that 1.68.1 was just release too; I'd rather that be handled in a subsequent PR to not have to go through CI again here, heh, but maybe I should (seems to only impact Windows though)?. Thanks in advance, and let me know if I can help with any additional info/context.

It fixes a compiler error: https://blog.rust-lang.org/2023/03/23/Rust-1.68.1.html
This one: rust-lang/rust#108162
But if it does not affect any of our code or dependencies, it is probably OK?
Considering, a subsequent upgrade to 1.68.1 should be relatively quick.

[brooksprumo]

The update seems trivial - no code changes :) And if the CI is passing, is there anything else to check?

I don't believe so. Sometimes the Rust upgrades are more substantial, but I didn't see anything in the release notes that was noteworthy.

It fixes a compiler error: https://blog.rust-lang.org/2023/03/23/Rust-1.68.1.html This one: rust-lang/rust#108162

Thanks for the links!

But if it does not affect any of our code or dependencies, it is probably OK? Considering, a subsequent upgrade to 1.68.1 should be relatively quick.

And yeah, that's what I was thinking too.