This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Refactor fullnode rotation test #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3015 +/- ##
========================================
- Coverage 76.8% 76.8% -0.1%
========================================
Files 130 130
Lines 19860 19861 +1
========================================
Hits 15261 15261
- Misses 4599 4600 +1 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3015 +/- ##
========================================
- Coverage 76.8% 76.8% -0.1%
========================================
Files 130 130
Lines 19860 19861 +1
========================================
Hits 15261 15261
- Misses 4599 4600 +1 |
garious
approved these changes
Feb 28, 2019
Merged
This was referenced Aug 4, 2021
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Oct 2, 2024
…kport of solana-labs#2990) (solana-labs#3015) excludes node's pubkey from bloom filter of pruned origins (solana-labs#2990) Bloom filter of pruned origins can return false positive for a node's own pubkey but a node should always be able to push its own values to other nodes in the cluster. (cherry picked from commit bce28c0) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The integration tests for leader rotation can share setup logic from existing tests. The code needs to be refactored into smaller functions.
Summary of Changes
Refactored the code, and updated the existing test to use the new functions.