This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
remove purge parameter to accounts
#2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2990 +/- ##
========================================
- Coverage 76.6% 76.6% -0.1%
========================================
Files 128 128
Lines 19624 19613 -11
========================================
- Hits 15049 15033 -16
- Misses 4575 4580 +5 |
sakridge
reviewed
Feb 28, 2019
| @@ -649,6 +646,16 @@ impl AccountsDB { | |||
| parents | |||
| } | |||
|
|
|||
| fn is_squashed(&self, fork: Fork) -> bool { | |||
| self.fork_info | |||
There was a problem hiding this comment.
This is kind of more expensive than the old way, but maybe it doesn't matter.
There was a problem hiding this comment.
what's the old way?
There was a problem hiding this comment.
checking the parent pointer on the bank.
There was a problem hiding this comment.
the duplication of state/logic was bugging me ;)
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Sep 27, 2024
…bs#2990) Bloom filter of pruned origins can return false positive for a node's own pubkey but a node should always be able to push its own values to other nodes in the cluster.
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Oct 2, 2024
…kport of solana-labs#2990) (solana-labs#3015) excludes node's pubkey from bloom filter of pruned origins (solana-labs#2990) Bloom filter of pruned origins can return false positive for a node's own pubkey but a node should always be able to push its own values to other nodes in the cluster. (cherry picked from commit bce28c0) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bank and Accounts were both keeping track of is_squashed()
Summary of Changes
remove Bank's tracking of Accounts.is_squashed()