This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
minimum-stake/rpc
branch
from
July 15, 2022 15:37
4be5cb7
to
2dc19b3
Compare
brooksprumo
commented
Jul 15, 2022
pub async fn get_stake_minimum_delegation(&self) -> ClientResult<u64> { | ||
let instruction = solana_sdk::stake::instruction::get_minimum_delegation(); | ||
let transaction = Transaction::new_with_payer(&[instruction], None); | ||
let response = self.simulate_transaction(&transaction).await?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old way of simulate_transaction()
does not actually work due to checks in load_account()
.
Resolved! |
mvines
previously approved these changes
Jul 16, 2022
CriesofCarrots
previously approved these changes
Jul 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ nit (alphabetizing RpcRequest variant)
joncinque
previously approved these changes
Jul 16, 2022
mergify
bot
dismissed stale reviews from mvines, CriesofCarrots, and joncinque
July 17, 2022 16:52
Pull request has been modified.
brooksprumo
added
the
automerge
Merge this Pull Request automatically once CI passes
label
Jul 17, 2022
Lcchy
pushed a commit
to Bonfida/solana
that referenced
this pull request
Jul 22, 2022
* Add RPC getStakeMinimumDelegation * fixup! rpc * fixup rpc * fixup rpc client mock sender * fixup docs * pr: sort
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is not an RPC method to get the stake minimum delegation.
Summary of Changes
Add one 😊
Fixes #24690