Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Add CLI to get stake minimum delegation #26645

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Add CLI to get stake minimum delegation #26645

merged 2 commits into from
Jul 21, 2022

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Jul 15, 2022 •
edited
Loading

Problem

There is not a way to query the stake minimum delegation from the CLI.

Summary of Changes

Add a new "stake-minimum-delegation" command.

Fixes #25202

@brooksprumo brooksprumo added the work in progress This isn't quite right yet label Jul 15, 2022
@brooksprumo brooksprumo force-pushed the minimum-stake/cli-get-minimum-delegation2 branch from a8ecbb4 to 3c7c6b7 Compare July 18, 2022 01:32
@brooksprumo brooksprumo added the noCI Suppress CI on this Pull Request label Jul 18, 2022
brooksprumo
brooksprumo commented Jul 18, 2022
View reviewed changes
cli/src/stake.rs Outdated Show resolved Hide resolved
@brooksprumo brooksprumo removed work in progress This isn't quite right yet noCI Suppress CI on this Pull Request labels Jul 18, 2022
@brooksprumo brooksprumo marked this pull request as ready for review July 18, 2022 17:17
t-nelson
t-nelson previously approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

should we also hook this up to solana delegate-stake and fail too small delegation attempts client-side so the user sees something nicer than some TransactionError? separate PR ofc

cli/src/stake.rs Outdated Show resolved Hide resolved
@brooksprumo brooksprumo mentioned this pull request Jul 20, 2022
Closed
@brooksprumo
Copy link
Contributor Author

should we also hook this up to solana delegate-stake and fail too small delegation attempts client-side so the user sees something nicer than some TransactionError? separate PR ofc

Good idea. I've created issue #26695 to track this.

@mergify mergify bot dismissed t-nelson’s stale review July 20, 2022 14:32

Pull request has been modified.

This was referenced Jul 20, 2022
Merged
Closed
@brooksprumo brooksprumo force-pushed the minimum-stake/cli-get-minimum-delegation2 branch from 49c3e32 to 6dab81c Compare July 21, 2022 03:29
@brooksprumo
Copy link
Contributor Author

Rebased now that #26697 has been merged. Updated to use commitment.

CriesofCarrots
CriesofCarrots approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm

@brooksprumo brooksprumo merged commit 8105b76 into solana-labs:master Jul 21, 2022
@brooksprumo brooksprumo deleted the minimum-stake/cli-get-minimum-delegation2 branch July 21, 2022 12:23
Lcchy pushed a commit to Bonfida/solana that referenced this pull request Jul 22, 2022
@brooksprumo @Lcchy
Add CLI to get stake minimum delegation (solana-labs#26645)
4ed5dee
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t-nelson t-nelson t-nelson left review comments

@CriesofCarrots CriesofCarrots CriesofCarrots approved these changes

@mvines mvines Awaiting requested review from mvines

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a way to get stake minimum delegation from CLI
3 participants
@brooksprumo @t-nelson @CriesofCarrots