Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Cover tests under clippy #10310

Merged
merged 1 commit into from
May 29, 2020
Merged

Conversation

ryoqun
Copy link
Contributor

@ryoqun ryoqun commented May 29, 2020

Problem

tests are not covered under clippy

Summary of Changes

Do so!
Great thanks to @svenski123 for precedent works #10030 #10172

Fixes #9951

@@ -25,7 +25,7 @@ fi
_ cargo +"$rust_stable" fmt --all -- --check

_ cargo +"$rust_stable" clippy --version
_ cargo +"$rust_stable" clippy --workspace -- --deny=warnings
_ cargo +"$rust_stable" clippy --workspace --tests -- --deny=warnings
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svenski123 Btw, I'd like to add --all-targets (this includes --benches), but currently I can't. Interested? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at #10445

@ryoqun ryoqun added the automerge Merge this Pull Request automatically once CI passes label May 29, 2020
@solana-grimes solana-grimes merged commit 8db3447 into solana-labs:master May 29, 2020
@ryoqun ryoqun changed the title Cover tests for clippy Cover tests under clippy May 29, 2020
@ryoqun
Copy link
Contributor Author

ryoqun commented Jun 9, 2020

This CI check is further enhanced by #10463 and #10464

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clippy errors in the test suite
3 participants