Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Clippy errors in the test suite #9951

Closed
garious opened this issue May 9, 2020 · 0 comments · Fixed by #10310
Closed

Clippy errors in the test suite #9951

garious opened this issue May 9, 2020 · 0 comments · Fixed by #10310
Labels
good first issue Good for newcomers
Milestone

Comments

@garious
Copy link
Contributor

garious commented May 9, 2020

Problem

CI isn't running Clippy over the tests configuration. There are lots of good warnings there, such as unnecessary clones that may be slowing execution down, and float comparisons that might add instability.

Steps to reproduce:

  1. cargo clippy --tests

Proposed Solution

Fix the warnings and errors. Once all fixed, enable the tests configuration (only) in CI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants