Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isSolanaRequest helper #3195

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Add isSolanaRequest helper #3195

merged 1 commit into from
Sep 11, 2024

Conversation

lorisleiva
Copy link
Contributor

@lorisleiva lorisleiva commented Sep 2, 2024

This PR adds a new isSolanaRequest helper function that checks if a given RpcRequest comes from the Solana RPC API.

This will be used — in a subsequent PR — to create a new Solana-RPC-specific HTTP transport that prevents loss of precision for large integers.

Copy link

changeset-bot bot commented Sep 2, 2024

⚠️ No Changeset found

Latest commit: 22b6118

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lorisleiva lorisleiva marked this pull request as ready for review September 2, 2024 15:05
@lorisleiva lorisleiva force-pushed the loris/json-stringify-with-bigints branch from c631810 to 3ed7380 Compare September 2, 2024 15:43
@lorisleiva lorisleiva force-pushed the loris/is-solana-request branch from fa57791 to 94e1ede Compare September 2, 2024 15:43
@lorisleiva lorisleiva force-pushed the loris/json-stringify-with-bigints branch from 3ed7380 to f563379 Compare September 2, 2024 15:47
@lorisleiva lorisleiva force-pushed the loris/is-solana-request branch from 94e1ede to 4d54dbb Compare September 2, 2024 15:47
@lorisleiva lorisleiva force-pushed the loris/json-stringify-with-bigints branch from f563379 to c5c040a Compare September 3, 2024 21:25
@lorisleiva lorisleiva force-pushed the loris/is-solana-request branch from 4d54dbb to 37e83c2 Compare September 3, 2024 21:25
@lorisleiva lorisleiva force-pushed the loris/json-stringify-with-bigints branch from c5c040a to 906eb43 Compare September 3, 2024 21:29
@lorisleiva lorisleiva force-pushed the loris/is-solana-request branch from 37e83c2 to d3a3d56 Compare September 3, 2024 21:29
@lorisleiva lorisleiva force-pushed the loris/json-stringify-with-bigints branch from 906eb43 to 5eb1545 Compare September 3, 2024 21:35
@lorisleiva lorisleiva force-pushed the loris/is-solana-request branch from d3a3d56 to cdf7109 Compare September 3, 2024 21:36
@lorisleiva lorisleiva force-pushed the loris/json-stringify-with-bigints branch from 5eb1545 to 0d567bb Compare September 3, 2024 22:11
@lorisleiva lorisleiva force-pushed the loris/is-solana-request branch from cdf7109 to 9f89fc6 Compare September 3, 2024 22:11
@lorisleiva lorisleiva force-pushed the loris/json-stringify-with-bigints branch from 0d567bb to 877f2ef Compare September 5, 2024 09:22
@lorisleiva lorisleiva force-pushed the loris/is-solana-request branch from 9f89fc6 to b159be0 Compare September 5, 2024 09:23
@lorisleiva lorisleiva force-pushed the loris/json-stringify-with-bigints branch from 877f2ef to 41378fc Compare September 6, 2024 11:49
@lorisleiva lorisleiva force-pushed the loris/is-solana-request branch from b159be0 to 26af60a Compare September 6, 2024 11:49
@lorisleiva lorisleiva force-pushed the loris/json-stringify-with-bigints branch from 41378fc to 97d86b7 Compare September 10, 2024 07:55
@lorisleiva lorisleiva force-pushed the loris/is-solana-request branch from 26af60a to 5c4c50b Compare September 10, 2024 07:55
@lorisleiva lorisleiva force-pushed the loris/json-stringify-with-bigints branch from 97d86b7 to 42cece0 Compare September 10, 2024 08:17
@lorisleiva lorisleiva force-pushed the loris/is-solana-request branch 2 times, most recently from 2d06c42 to d566b79 Compare September 10, 2024 08:51
@lorisleiva lorisleiva changed the base branch from loris/json-stringify-with-bigints to loris/extract-is-json-rpc-payload September 10, 2024 08:51
@lorisleiva lorisleiva force-pushed the loris/is-solana-request branch from d566b79 to 7dbb7d1 Compare September 10, 2024 09:01
@lorisleiva lorisleiva force-pushed the loris/extract-is-json-rpc-payload branch from 0d92cd7 to 2b4def2 Compare September 10, 2024 10:13
@lorisleiva lorisleiva force-pushed the loris/is-solana-request branch from 7dbb7d1 to f2d3b70 Compare September 10, 2024 10:13
Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

Copy link
Contributor Author

lorisleiva commented Sep 11, 2024

Merge activity

  • Sep 11, 4:12 AM EDT: @lorisleiva started a stack merge that includes this pull request via Graphite.
  • Sep 11, 4:23 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 11, 4:24 AM EDT: @lorisleiva merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from loris/extract-is-json-rpc-payload to graphite-base/3195 September 11, 2024 08:19
@lorisleiva lorisleiva changed the base branch from graphite-base/3195 to master September 11, 2024 08:21
@lorisleiva lorisleiva force-pushed the loris/is-solana-request branch from f2d3b70 to 22b6118 Compare September 11, 2024 08:22
@lorisleiva lorisleiva merged commit 89a25aa into master Sep 11, 2024
7 checks passed
@lorisleiva lorisleiva deleted the loris/is-solana-request branch September 11, 2024 08:24
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants