Make RpcResponse provide the resopnse payload directly

[lorisleiva]

This PR reverts some of the changes in the previous stack by making the following key change:

// Before.
type RpcResponse<TResponse = unknown> = {
    readonly json: () => Promise<TResponse>;
    readonly text: () => Promise<string>;
};

// After.
type RpcResponse<TResponse = unknown> = TResponse;

This is because we no longer believe that it is the responsibility of the RPC API to affect the response as text or JSON. This aspect should be encapsulated by the RPC Transport layer, meaning any custom JSON parsing/stringifying will need to be done at the RPC Transport layer.

Note that, we could simply delete the RpcResponse type since it returns its type parameter directly but keeping it makes the code clearer as we will use RpcResponse instead of unknown everywhere in the codebase.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4f05c0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[lorisleiva]

• Use createHttpTransportForSolanaRpc in default transport #3197
• Add createHttpTransportForSolanaRpc function #3196
• Add isSolanaRequest helper #3195
• Add stringifyJsonWithBigInts helper #3194
• Add parseJsonWithBigInts helper #3193
• Add fromJson and toJson options to HTTP transport #3192
• Make RPC transports responsible for preparing payloads #3186
• Make RpcResponse provide the resopnse payload directly #3185 👈
• Remove temporary fix for Agave issue 479 #3184
• Update getClusterNodes response #3201
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lorisleiva and the rest of your teammates on Graphite

[steveluscher]

[steveluscher]

I guess this was the clue, all along.

[lorisleiva]

Merge activity

• Sep 10, 3:48 AM EDT: @lorisleiva started a stack merge that includes this pull request via Graphite.
• Sep 10, 3:52 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 10, 3:53 AM EDT: @lorisleiva merged this pull request with Graphite.

[github-actions]

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.