Send mails in chunks

config-examples/mailsender-config.json

@@ -10,5 +10,6 @@
   "sender-name": "Softwerkskammer Benachrichtigungen",
   "sender-address": "info@my-domain.org",
   "include-footer": false,
-  "doNotSendMails": "insert email address here for local development as replacement for receivers"
+  "doNotSendMails": "insert email address here for local development as replacement for receivers",
+  "maxMailSendingChunkSize": 3
 }

softwerkskammer/lib/commons/statusmessage.js

@@ -38,4 +38,8 @@ module.exports = {
   successMessage: function successMessage(title, text, additionalArguments) {
     return statusMessage("alert-success", title, text, additionalArguments);
   },
+
+  isErrorMessage: function isErrorMessage(statusmessage) {
+    return statusmessage.contents().type === "alert-danger";
+  },
 };

softwerkskammer/lib/mailsender/index.js

@@ -23,19 +23,19 @@ async function messageSubmitted(req, res) {
 
   async function doTheRightSending() {
     if (req.body.massMailing === "members") {
-      return mailsenderService.sendMailToAllMembers(message);
+      return mailsenderService.sendMailToAllMembers(message, req.user.member);
     }
     const activityURL = req.body.successURL.replace("/activities/", "");
     if (req.body.toParticipants) {
       message.removeAllButFirstButton();
       return mailsenderService.sendMailToParticipantsOf(activityURL, message);
     }
     if (req.body.invitedGroups) {
-      return mailsenderService.sendMailToInvitedGroups(req.body.invitedGroups, activityURL, message);
+      return mailsenderService.sendMailToInvitedGroups(req.body.invitedGroups, activityURL, message, req.user.member);
     }
     if (req.body.groupName) {
       message.subject = `[${req.body.emailPrefix}] ${message.subject}`;
-      return mailsenderService.sendMailToInvitedGroups([req.body.groupName], undefined, message);
+      return mailsenderService.sendMailToInvitedGroups([req.body.groupName], undefined, message, req.user.member);
     }
     if (req.body.nickname) {
       return mailsenderService.sendMailToMember(req.body.nickname, message);

softwerkskammer/lib/mailsender/mailsenderService.js

@@ -1,6 +1,7 @@
 "use strict";
 const { DateTime } = require("luxon");
 const conf = require("simple-configure");
+const R = require("ramda");
 const logger = require("winston").loggers.get("application");
 
 const beans = conf.get("beans");
@@ -17,6 +18,7 @@ const Group = beans.get("group");
 const misc = beans.get("misc");
 
 const mailtransport = beans.get("mailtransport");
+const statusmessage = beans.get("statusmessage");
 
 async function sendMail(message, type) {
   return mailtransport.sendMail(message, type, conf.get("sender-address"), conf.get("include-footer"));
@@ -38,6 +40,38 @@ function activityMarkdown(activity, language) {
   return markdown;
 }
 
+function createChunkedSendingReportMessage(statusmessages, subject, sender) {
+  const anySendingError = R.any(statusmessage.isErrorMessage, statusmessages);
+  const resultMessage = new Message(
+    {
+      subject,
+      markdown: anySendingError
+        ? `Fehler: ${statusmessages.map((s) => s.contents().additionalArguments.err).join(" ")}`
+        : "E-Mails erfolgreich versendet",
+    },
+    sender,
+  );
+  resultMessage.setTo(sender.email());
+  return resultMessage;
+}
+
+async function sendMailInChunks(maxMailSendingChunkSize, allMembers, message, type, sender) {
+  const membersInChunks = R.splitEvery(maxMailSendingChunkSize, allMembers);
+
+  try {
+    const statusmessages = await Promise.all(
+      membersInChunks.map((bccs) => {
+        message.setBccToMemberAddresses(bccs);
+        return sendMail(message, type);
+      }),
+    );
+    const resultMessage = createChunkedSendingReportMessage(statusmessages, `Report "${message.subject}"`, sender);
+    await sendMail(resultMessage, type);
+  } catch (err) {
+    logger.error(err);
+  }
+}
+
 module.exports = {
   activityMarkdown,
 
@@ -97,7 +131,7 @@ module.exports = {
     }
   },
 
-  sendMailToInvitedGroups: async function sendMailToInvitedGroups(invitedGroups, activityURL, message) {
+  sendMailToInvitedGroups: async function sendMailToInvitedGroups(invitedGroups, activityURL, message, sender) {
     const type = "$t(mailsender.invitation)";
     try {
       const groups = groupsService.getGroups(invitedGroups);
@@ -106,7 +140,11 @@ module.exports = {
       }
       try {
         groups.forEach(groupsAndMembersService.addMembersToGroup);
-        message.setBccToGroupMemberAddresses(groups);
+        const allMembers = R.uniqBy(
+          (member) => member.email(),
+          groups.flatMap((group) => group.members),
+        );
+
         let activity;
         try {
           activity = activitystore.getActivity(activityURL);
@@ -116,7 +154,17 @@ module.exports = {
         if (activity) {
           message.setIcal(icalService.activityAsICal(activity).toString());
         }
-        return sendMail(message, type);
+
+        const maxMailSendingChunkSize = conf.get("maxMailSendingChunkSize");
+        if (allMembers.length > maxMailSendingChunkSize) {
+          // noinspection ES6MissingAwait - we explicitly don't want to wait because that could cause timeouts
+          sendMailInChunks(maxMailSendingChunkSize, allMembers, message, type, sender);
+
+          return mailtransport.statusmessageForSuccess();
+        } else {
+          message.setBccToMemberAddresses(allMembers);
+          return sendMail(message, type);
+        }
       } catch (err1) {
         return mailtransport.statusmessageForError(type, err1);
       }
@@ -140,11 +188,14 @@ module.exports = {
     }
   },
 
-  sendMailToAllMembers: async function sendMailToAllMembers(message) {
+  sendMailToAllMembers: async function sendMailToAllMembers(message, sender) {
     const type = "$t(mailsender.notification)";
     const members = memberstore.allMembers();
-    message.setBccToMemberAddresses(members);
-    return sendMail(message, type);
+
+    // noinspection ES6MissingAwait - we explicitly don't want to wait because that could cause timeouts
+    sendMailInChunks(conf.get("maxMailSendingChunkSize"), members, message, type, sender);
+
+    return mailtransport.statusmessageForSuccess();
   },
 
   sendMagicLinkToMember: async function sendMagicLinkToMember(member, token) {