Send mails in chunks #1509
Merged
Send mails in chunks #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UrsMetz
force-pushed
the
send-mails-in-chunks
branch
from
9b41218 to
ae0a279
Compare
leider
requested changes
Nov 10, 2024
|
Die Tests habe ich mir noch nicht im Detail angesehen |
leider
reviewed
Nov 10, 2024
|
Danke fürs Feedback @leider, schaue ich mir die nächsten Tage genau an, heute schaffe ich das nicht mehr. |
UrsMetz
force-pushed
the
send-mails-in-chunks
branch
from
b558368 to
aa0d086
Compare
UrsMetz
force-pushed
the
send-mails-in-chunks
branch
from
aa0d086 to
07c3c4f
Compare
leider
reviewed
Nov 19, 2024
|
@leider habe jetzt entweder die gewünschten Änderungen gemacht bzw. bei einigen Sachen Fragen/Meinungen hinterlassen. |
leider
reviewed
Dec 3, 2024
# Conflicts: # softwerkskammer/lib/mailsender/mailsenderService.js # softwerkskammer/testutil/abstractConfigureForTest.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Für die Mails an Gruppen (Einladungen als auch Mails an alle in der Gruppe) und die Superuser-Funktion an alle Members zu senden, erlaubt die Änderung in diesem PR, dass man die Mails in einer konfigurierbaren Chunk-Aufteilung versendet.
Damit das Versenden noch geht, muss zwingend eine maximale Chunk-Größe konfigurieren, daher habe ich auch die
mailsender-config.jsoninconfig-examplesangepasst.Hoffentlich fixes #1456