[RN 0.75 new arch] 'utils/RectUtil.h' file not found #2306

jankosecki · 2024-08-14T17:58:42Z

Description

Hi team,

I've been testing upgrading RN 0.74 to 0.75-RC7 with basic stack including react-navigation and react-native-screens.
The iOS build fails for me with the following error:

In file included from /Users/jkosecki/repos/custom/ReactNativeUpgradeTester/node_modules/react-native-screens/ios/RNSScreen.mm:15:
/Users/jkosecki/repos/custom/ReactNativeUpgradeTester/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h:10:10: fatal error: 'utils/RectUtil.h' file not found
#include "utils/RectUtil.h"

I have applied the following patch locally (included in the reproduction repo):

diff --git a/node_modules/react-native-screens/RNScreens.podspec b/node_modules/react-native-screens/RNScreens.podspec
index be7cc24..14cd2e4 100644
--- a/node_modules/react-native-screens/RNScreens.podspec
+++ b/node_modules/react-native-screens/RNScreens.podspec
@@ -27,7 +27,7 @@ Pod::Spec.new do |s|
     s.subspec "common" do |ss|
       ss.source_files         = ["common/cpp/**/*.{cpp,h}", "cpp/**/*.{cpp,h}"]
       ss.header_dir           = "rnscreens"
-      ss.pod_target_xcconfig  = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/common/cpp\"" }
+      ss.pod_target_xcconfig  = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/common/cpp/react/renderer/components/\"" }
     end
   end

but I'm not sure if that's correct way to fix this issue.

Steps to reproduce

Remove patches/react-native-screens+3.34.0.patch
Run yarn setup && yarn ios

Snack or a link to a repository

https://github.com/jankosecki/react-native-upgrade-tester/tree/rn-0.75

Screens version

3.34.0

React Native version

0.75-RC7

Platforms

iOS

JavaScript runtime

Hermes

Workflow

React Native (without Expo)

Architecture

Fabric (New Architecture)

Build type

Debug mode

Device

None

Device model

No response

Acknowledgements

Yes

The text was updated successfully, but these errors were encountered:

necmettindev · 2024-08-16T05:26:08Z

same issue

nthtrung09it · 2024-08-17T04:13:39Z

same issue

rayson-intrack · 2024-08-19T06:12:42Z

same issue

tboba · 2024-08-19T14:12:22Z

Hey, thanks for posting this issue!
Unfortunately, I can't reproduce this bug with the reproducer you provided. After removing patch I'm not receiving any error during the pod install phase, nor the compile phase.
Is this reproducer correct? I can't find any line for enabling new architecture in this repro 🤔

0xDing · 2024-08-19T17:36:07Z

same issue +1

tboba · 2024-08-20T10:15:08Z

@necmettindev @nthtrung09it @rayson-intrack @0xDing could you provide a reproducer that reproduces this issue? As I said above, I didn't manage to deduce any bug from provided RN project (even after removing the patch).

jankosecki · 2024-08-20T11:40:34Z

@tboba
I can reproduce the issues using provided repo. I did the following steps:

Delete patches/react-native-screens+3.34.0.patch
Clean up node_modules in case patch already applied
Run yarn setup (it invokes "pod-install": "(cd ./ios ; RCT_NEW_ARCH_ENABLED=1 USE_FRAMEWORKS=static bundle exec pod install --repo-update)" which enables new architecture)
Open XCode to set up development team (provided repro contains None team in Signing & Capabilities)
Run yarn start
Run yarn ios or trigger build from XCode (yarn ios causes a massive error output with different "error" lines but XCode offers a clear reason:

matinzd · 2024-08-20T14:20:10Z

This is also happening in 0.75.2. Seems like there is something wrong with the pod installation in 75.

I tried this patch but it didn't work. (Fixed the issue but other errors started to come up)

diff --git a/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h b/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h
index 37aac4e..5fb5505 100644
--- a/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h
+++ b/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h
@@ -6,8 +6,8 @@
 #include <react/debug/react_native_assert.h>
 #include <react/renderer/components/rnscreens/Props.h>
 #include <react/renderer/core/ConcreteComponentDescriptor.h>
+#include <react/renderer/components/rnscreens/utils/RectUtil.h>
 #include "RNSScreenShadowNode.h"
-#include "utils/RectUtil.h"
 
 namespace facebook {
 namespace react {

With that being said, there is something wrong with the headers linking.

New arch is turned on.

FurySwordXD · 2024-08-22T14:30:01Z

Can reproduce on RN 0.75.2.
Using this patch seems to fix it.

This is also happening in 0.75.2. Seems like there is something wrong with the pod installation in 75.

I tried this patch but it didn't work. (Fixed the issue but other errors started to come up)

diff --git a/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h b/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h
index 37aac4e..5fb5505 100644
--- a/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h
+++ b/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h
@@ -6,8 +6,8 @@
 #include <react/debug/react_native_assert.h>
 #include <react/renderer/components/rnscreens/Props.h>
 #include <react/renderer/core/ConcreteComponentDescriptor.h>
+#include <react/renderer/components/rnscreens/utils/RectUtil.h>
 #include "RNSScreenShadowNode.h"
-#include "utils/RectUtil.h"
 
 namespace facebook {
 namespace react {

With that being said, there is something wrong with the headers linking.

New arch is turned on.

@matinzd Could you highlight what are the other errors that were introduced, I don't use this library directly but through "react-navigation" and I don't face any other issues/errors.

WoLewicki · 2024-08-23T08:56:37Z

#include <react/renderer/components/rnscreens/utils/RectUtil.h> instead of #include "utils/RectUtil.h" seems to work in my setups.

cjones26 · 2024-08-23T20:34:45Z

Same issue +1

TowhidKashem · 2024-08-26T02:01:40Z

same issue +1

tboba · 2024-08-26T09:36:21Z

@matinzd this patch sounds better. Thanks!

matinzd · 2024-08-26T09:38:34Z

~~Should I open a PR for that?~~ Is that gonna break paper builds?

tboba · 2024-08-26T10:01:35Z

@matinzd Nope, it shouldn't. C++ layer is being built only on new architecture, so the old arch should work well 👍

…ts (#2319) ## Description In the newest version of screens, there's a bug where compiler can't find RectUtil.h file from `utils/RectFile.h` during the compile phase of RNSScreenComponentDescriptor file. This PR fixes this by changing the path of RectUtil.h file to <react/renderer/components/rnscreens/util/RectFile.h> file. Fixes #2306. ## Changes - Changed import of RectUtil.h file in RNSScreenComponentDescriptor.h file ## Test code and steps to reproduce - Download reproducer from https://github.com/jankosecki/react-native-upgrade-tester/tree/rn-0.75 - Delete patches/react-native-screens+3.34.0.patch - Clean up node_modules in case patch already applied - Run yarn setup (it invokes "pod-install": "(cd ./ios ; RCT_NEW_ARCH_ENABLED=1 USE_FRAMEWORKS=static bundle exec pod install --repo-update)" which enables new architecture) - Open XCode to set up development team (provided repro contains None team in Signing & Capabilities) - Run yarn start - Run yarn ios or trigger build from XCode (yarn ios causes a massive error output with different "error" lines but XCode offers a clear reason. ## Checklist - [ ] Ensured that CI passes

matinzd · 2024-09-13T11:57:14Z

Any plans to release this change?

cjones26 · 2024-09-25T18:11:20Z

It's been almost two months...this may hold up one of our releases and we really don't want to have to fork. Can you please provide a timeline on when it will be published?

jaaywags · 2024-09-28T16:27:45Z

#include <react/renderer/components/rnscreens/utils/RectUtil.h>

YES this worked for me too! Not ideal solution but at least we can move forward until the fix is released.

…ts (software-mansion#2319) ## Description In the newest version of screens, there's a bug where compiler can't find RectUtil.h file from `utils/RectFile.h` during the compile phase of RNSScreenComponentDescriptor file. This PR fixes this by changing the path of RectUtil.h file to <react/renderer/components/rnscreens/util/RectFile.h> file. Fixes software-mansion#2306. ## Changes - Changed import of RectUtil.h file in RNSScreenComponentDescriptor.h file ## Test code and steps to reproduce - Download reproducer from https://github.com/jankosecki/react-native-upgrade-tester/tree/rn-0.75 - Delete patches/react-native-screens+3.34.0.patch - Clean up node_modules in case patch already applied - Run yarn setup (it invokes "pod-install": "(cd ./ios ; RCT_NEW_ARCH_ENABLED=1 USE_FRAMEWORKS=static bundle exec pod install --repo-update)" which enables new architecture) - Open XCode to set up development team (provided repro contains None team in Signing & Capabilities) - Run yarn start - Run yarn ios or trigger build from XCode (yarn ios causes a massive error output with different "error" lines but XCode offers a clear reason. ## Checklist - [ ] Ensured that CI passes

github-actions bot added Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided labels Aug 14, 2024

tboba self-assigned this Aug 19, 2024

tboba added the Close when stale This issue is going to be closed when there is no activity for a while label Aug 19, 2024

github-actions bot removed the Close when stale This issue is going to be closed when there is no activity for a while label Aug 19, 2024

matinzd mentioned this issue Aug 22, 2024

[0.75.0-rc.2]: regression on linking iOS dependencies with script phase (e.g. RN Firebase): reactwg/react-native-releases#341

Closed

tboba mentioned this issue Aug 26, 2024

fix(iOS): Change import of RectUtil.h file to react/renderer/components #2319

Merged

1 task

tboba closed this as completed in #2319 Aug 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RN 0.75 new arch] 'utils/RectUtil.h' file not found #2306

[RN 0.75 new arch] 'utils/RectUtil.h' file not found #2306

jankosecki commented Aug 14, 2024 •

edited

Loading

necmettindev commented Aug 16, 2024

nthtrung09it commented Aug 17, 2024

rayson-intrack commented Aug 19, 2024

tboba commented Aug 19, 2024

0xDing commented Aug 19, 2024

tboba commented Aug 20, 2024

jankosecki commented Aug 20, 2024

matinzd commented Aug 20, 2024 •

edited

Loading

FurySwordXD commented Aug 22, 2024 •

edited

Loading

WoLewicki commented Aug 23, 2024

cjones26 commented Aug 23, 2024

TowhidKashem commented Aug 26, 2024

tboba commented Aug 26, 2024

matinzd commented Aug 26, 2024 •

edited

Loading

tboba commented Aug 26, 2024

matinzd commented Sep 13, 2024

cjones26 commented Sep 25, 2024

jaaywags commented Sep 28, 2024

[RN 0.75 new arch] 'utils/RectUtil.h' file not found #2306

[RN 0.75 new arch] 'utils/RectUtil.h' file not found #2306

Comments

jankosecki commented Aug 14, 2024 • edited Loading

Description

Steps to reproduce

Snack or a link to a repository

Screens version

React Native version

Platforms

JavaScript runtime

Workflow

Architecture

Build type

Device

Device model

Acknowledgements

necmettindev commented Aug 16, 2024

nthtrung09it commented Aug 17, 2024

rayson-intrack commented Aug 19, 2024

tboba commented Aug 19, 2024

0xDing commented Aug 19, 2024

tboba commented Aug 20, 2024

jankosecki commented Aug 20, 2024

matinzd commented Aug 20, 2024 • edited Loading

FurySwordXD commented Aug 22, 2024 • edited Loading

WoLewicki commented Aug 23, 2024

cjones26 commented Aug 23, 2024

TowhidKashem commented Aug 26, 2024

tboba commented Aug 26, 2024

matinzd commented Aug 26, 2024 • edited Loading

tboba commented Aug 26, 2024

matinzd commented Sep 13, 2024

cjones26 commented Sep 25, 2024

jaaywags commented Sep 28, 2024

jankosecki commented Aug 14, 2024 •

edited

Loading

matinzd commented Aug 20, 2024 •

edited

Loading

FurySwordXD commented Aug 22, 2024 •

edited

Loading

matinzd commented Aug 26, 2024 •

edited

Loading