Skip to content

Commit

Permalink
fix(iOS): Change import of RectUtil.h file to react/renderer/componen…
Browse files Browse the repository at this point in the history
…ts (software-mansion#2319)

## Description

In the newest version of screens, there's a bug where compiler can't
find RectUtil.h file from `utils/RectFile.h` during the compile phase of
RNSScreenComponentDescriptor file.
This PR fixes this by changing the path of RectUtil.h file to
<react/renderer/components/rnscreens/util/RectFile.h> file.

Fixes software-mansion#2306.

## Changes

- Changed import of RectUtil.h file in RNSScreenComponentDescriptor.h
file

## Test code and steps to reproduce

- Download reproducer from
https://github.com/jankosecki/react-native-upgrade-tester/tree/rn-0.75
- Delete patches/react-native-screens+3.34.0.patch
- Clean up node_modules in case patch already applied
- Run yarn setup (it invokes "pod-install": "(cd ./ios ;
RCT_NEW_ARCH_ENABLED=1 USE_FRAMEWORKS=static bundle exec pod install
--repo-update)" which enables new architecture)
- Open XCode to set up development team (provided repro contains None
team in Signing & Capabilities)
- Run yarn start
- Run yarn ios or trigger build from XCode (yarn ios causes a massive
error output with different "error" lines but XCode offers a clear
reason.

## Checklist

- [ ] Ensured that CI passes
  • Loading branch information
tboba authored and ja1ns committed Oct 9, 2024
1 parent a87a1ac commit 6da6055
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
#endif
#include <react/debug/react_native_assert.h>
#include <react/renderer/components/rnscreens/Props.h>
#include <react/renderer/components/rnscreens/utils/RectUtil.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
#include "RNSScreenShadowNode.h"
#include "utils/RectUtil.h"

namespace facebook {
namespace react {
Expand Down

0 comments on commit 6da6055

Please sign in to comment.