-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Build Error RN 0.73 - New Architecture #1985
Comments
Hi @AlirezaHadjar, thanks for reporting this issue. As we're already done with supporting RN 0.73, we plan to release a new version of react-native-screens shortly. Could you check if the version taken from the "react-native-screens": "software-mansion/react-native-screens#main" cc @booyeu could you also check that? |
@tboba Thank you for the update. Yeah, I just tested the |
Hi @AlirezaHadjar @booyeu! I'm happy to say that we've released new version of react-native-screens (3.29.0) which has a support for React Native 0.73 onboard! 🥳 Check it out! If you find something wrong related to the newest version (this change is still buggy or doesn't work for you) let us know 🎉 |
Still necessary to do the react-native-screens override in the MainActivity file? Because it's not compiling here with it. |
I have the same issue with
|
@bulkinav this looks like you're running your application with Fabric turned on, right? In this case we support only the latest version of React Native, so to run 3.29 on Fabric you need React Native 0.73.x. This is the case, because for almost every ReactNative version breaking changes are merged to React Native repository (such as this one you reported, changing function signatures) that we can not keep up otherwise. I guess you made me just aware, that we have not put that in our readme 🤦🏻 |
Do you mind posting a stacktrace / errors from build? (and your MainActivity file) |
…th Fabric (#2001) ## Description So in [discussion](#1985 (comment)) of #1985 I was just made aware that we did not update supported react-native versions in our readme, leading to some confusion. ## Changes Updated the readme & also release notes of 3.28.0 ## Test code and steps to reproduce N/A ## Checklist - [x] Ensured that CI passes
…th Fabric (#2001) ## Description So in [discussion](software-mansion/react-native-screens#1985 (comment)) of #1985 I was just made aware that we did not update supported react-native versions in our readme, leading to some confusion. ## Changes Updated the readme & also release notes of 3.28.0 ## Test code and steps to reproduce N/A ## Checklist - [x] Ensured that CI passes
I am also having this error with RN
Do we understand where this is coming from? |
Not really @aymather. If you can reproduce this error on fresh RN project then I might consider this a bug. Otherwise it's something setup specific (e.g. invalid cache, some wrong dependency version etc.). I'm working daily on 0.74.2 with new architecture & it works fine on my setup. |
Confirm, that it works on: but has build issues on 0.74.4 and 3.33.0 |
3.33.0 supports only react-native 0.75.0-rc.5+, the library won't build with any other version due to breaking changes in |
Hey @kkafar, I'm sorry, but I've tried React Native 0.74.4 with react-native-screens versions 3.32, 3.31.1, and 3.31.0, and I still experience build failures and the same error as reported in this issue. I haven't tried any versions below those yet |
@Rakha112 and following these steps if u encountering errors like this IOS build issue resolving rm -rf ~/Library/Developer/Xcode/DerivedData |
Hey @lukachi, using React Native 0.74.2 and react-native-screens 3.32.0 on Android newArch builds successfully. Thank you very much. So, for now, it seems we can't use react-native-screens with React Native version 0.74.4, right? |
If react-native published some breaking changes between patch version 0.74.2 and 0.74.4 then it's not on this library. Yeah I know, that from your perspective it does not matter who breaks the build, but only that the build is broken, but from the library perspective we can't even do a patch for 0.74.4, because that would require changes in native code, thus it would require minor version bump in So yeah, the only viable option is to stick to a little bit older patch version of react-native of upgrade :/ |
Thank you very much for your detailed explanation. I understand the situation now. I apologize if my previous comments caused any misunderstanding Thank you again for your help! |
…th Fabric (software-mansion#2001) ## Description So in [discussion](software-mansion#1985 (comment)) of software-mansion#1985 I was just made aware that we did not update supported react-native versions in our readme, leading to some confusion. ## Changes Updated the readme & also release notes of 3.28.0 ## Test code and steps to reproduce N/A ## Checklist - [x] Ensured that CI passes
Any suggestions on how to avoid getting this error, randomly, only at pipeline level, with react native 0.75.3? I was constantly getting this error on lower levels of react-native-screens so I updated it to |
Description
There's a build issue on Android while building the newly initialized app.
Steps to reproduce
react-native-screens
:New Architecture
:Snack or a link to a repository
https://github.com/AlirezaHadjar/rnscreensRN73BuildError.git
Screens version
3.27.0
React Native version
0.73.0
Platforms
Android
JavaScript runtime
Hermes
Workflow
React Native (without Expo)
Architecture
Fabric (New Architecture)
Build type
Debug mode
Device
Android emulator
Device model
Nexus 5X
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: