Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(align-deps): ensure react-native-screens works with New Arch #2963

Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix(align-deps): ensure react-native-screens works with New Arch #2963

merged 2 commits into from
Feb 9, 2024

Conversation

balazsgerlei
Copy link
Contributor

@balazsgerlei balazsgerlei commented Feb 9, 2024 •
edited
Loading

Description

react-native-screens 3.28.0 broke compatibility with 0.72 + New Arch. See also discussion for more evidence.

Test plan

n/a

@balazsgerlei
Copy link
Contributor Author

@microsoft-github-policy-service agree

tido64
tido64 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@tido64 tido64 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Can you also run yarn change at root and push a change log? This ensures that a new version will get published in the next round.

@balazsgerlei
Copy link
Contributor Author

balazsgerlei commented Feb 9, 2024 •
edited
Loading

Sure, I've committed the changeset - hope I did it right as this is my first contribution to this repo! So exciting. 🤩

I tried to do everything as you did in #2907 which was a very similar change.

@tido64 tido64 merged commit 8dcfd1e into microsoft:main Feb 9, 2024
10 checks passed
@tido64
Copy link
Member

tido64 commented Feb 9, 2024

Thanks again! Have a nice weekend 😊

@balazsgerlei
Copy link
Contributor Author

Have a nice weekend too!

@balazsgerlei balazsgerlei deleted the ensure-react-native-screens-works-with-new-arch branch February 21, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tido64 tido64 tido64 approved these changes

@kelset kelset Awaiting requested review from kelset

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balazsgerlei @tido64